Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/recovery/recovery_install_global_error.cc

Index: chrome/browser/recovery/recovery_install_global_error.cc
diff --git a/chrome/browser/recovery/recovery_install_global_error.cc b/chrome/browser/recovery/recovery_install_global_error.cc
index 737647cab5e3281df25641d2007e54a0faddc3ad..8e2964a010146741758cd82c6790e6813b7769c7 100644
--- a/chrome/browser/recovery/recovery_install_global_error.cc
+++ b/chrome/browser/recovery/recovery_install_global_error.cc
@@ -23,7 +23,8 @@ RecoveryInstallGlobalError::RecoveryInstallGlobalError(Profile* profile)
         : elevation_needed_(false),
           profile_(profile),
           has_shown_bubble_view_(false) {
-  GlobalErrorServiceFactory::GetForProfile(profile_)->AddGlobalError(this);
+  GlobalErrorServiceFactory::GetForProfile(profile_)->AddUnownedGlobalError(
+      this);

[Nico, 2016/10/10 14:03:37]

this ctor has only one call, so making this use the owned variant should be
possible as well
(https://cs.chromium.org/chromium/src/chrome/browser/recovery/recovery_install...)

[Avi (use Gerrit), 2016/10/10 16:52:36]

Done.

[Avi (use Gerrit), 2016/10/17 00:19:27]

This got past what I was comfortable doing, so no.

 
   PrefService* pref = g_browser_process->local_state();
   if (pref->FindPreference(prefs::kRecoveryComponentNeedsElevation)) {
@@ -46,7 +47,8 @@ RecoveryInstallGlobalError::~RecoveryInstallGlobalError() {
 }
 
 void RecoveryInstallGlobalError::Shutdown() {
-  GlobalErrorServiceFactory::GetForProfile(profile_)->RemoveGlobalError(this);
+  GlobalErrorServiceFactory::GetForProfile(profile_)->RemoveUnownedGlobalError(
+      this);
 }
 
 GlobalError::Severity RecoveryInstallGlobalError::GetSeverity() {