Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/extensions/external_install_error.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_install_error.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 295 matching lines @@
   webstore_data_fetcher_.reset(new WebstoreDataFetcher(
       this,
       content::BrowserContext::GetDefaultStoragePartition(browser_context_)->
           GetURLRequestContext(),
       GURL(), extension_id_));
   webstore_data_fetcher_->Start();
 }
 
 ExternalInstallError::~ExternalInstallError() {
   if (global_error_.get())
-    error_service_->RemoveGlobalError(global_error_.get());
+    error_service_->RemoveUnownedGlobalError(global_error_.get());
 }
 
 void ExternalInstallError::OnInstallPromptDone(
     ExtensionInstallPrompt::Result result) {
   const Extension* extension = GetExtension();
 
   // If the error isn't removed and deleted as part of handling the user's
   // response (which can happen, e.g., if an uninstall fails), be sure to remove
   // the error directly in order to ensure it's not called twice.
   base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ skipping 104 matching lines @@
                                      weak_factory_.GetWeakPtr()));
 }
 
 void ExternalInstallError::OnDialogReady(
     ExtensionInstallPromptShowParams* show_params,
     const ExtensionInstallPrompt::DoneCallback& callback,
     std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt) {
   prompt_ = std::move(prompt);
 
   if (alert_type_ == BUBBLE_ALERT) {
     global_error_.reset(new ExternalInstallBubbleAlert(this, prompt_.get()));

[Nico, 2016/10/10 14:03:37]

This one looks like it could be a weak ptr and this class could use the
AddOwned() version throughout

[Avi (use Gerrit), 2016/10/10 16:52:36]

The GlobalErrorService is a PKS, and is guaranteed to outlive this, so I'm
making it a weak pointer.

-    error_service_->AddGlobalError(global_error_.get());
+    error_service_->AddUnownedGlobalError(global_error_.get());
 
     if (!manager_->has_currently_visible_install_alert()) {
       // |browser| is nullptr during unit tests, so call
       // DidChangeInstallAlertVisibility() regardless because we depend on this
       // in unit tests.
       manager_->DidChangeInstallAlertVisibility(this, true);
       Browser* browser = chrome::FindTabbedBrowser(
           Profile::FromBrowserContext(browser_context_), true);
       if (browser)
         global_error_->ShowBubbleView(browser);
     }
   } else {
     DCHECK(alert_type_ == MENU_ALERT);
     global_error_.reset(new ExternalInstallMenuAlert(this));
-    error_service_->AddGlobalError(global_error_.get());
+    error_service_->AddUnownedGlobalError(global_error_.get());
   }
 }
 
 void ExternalInstallError::RemoveError() {
   manager_->RemoveExternalInstallError(extension_id_);
 }
 
 }  // namespace extensions