Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Issue 24067002: MIPS/ARM: Fix benchmarks failures on simulator.

Created:
7 years, 3 months ago by palfia
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS/ARM: Fix benchmarks failures on simulator. The default x87 FPU precision is usually 80-bit extended precision, which can lead to precision failures on several tests. This patch fixes the precision failures on simulator by setting the x87 FPU precision to 64-bit double precision. TEST=benchmarks/sunspider/3d-cube, benchmarks/sunspider/3d-raytrace, benchmarks/sunspider/access-nbody, benchmarks/sunspider/math-partial-sums BUG=

Patch Set 1 #

Patch Set 2 : Cleanup & ARM port #

Patch Set 3 : Fix ARM port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M src/arm/simulator-arm.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
PTAL.
7 years, 3 months ago (2013-09-09 13:41:53 UTC) #1
Paul Lind
LTGM, but we need v8 team to review the ARM fix as well. PTAL.
7 years, 3 months ago (2013-09-09 15:23:46 UTC) #2
Yang
On 2013/09/09 15:23:46, Paul Lind wrote: > LTGM, but we need v8 team to review ...
7 years, 3 months ago (2013-09-10 16:47:34 UTC) #3
Paul Lind
On 2013/09/10 16:47:34, Yang wrote: > I don't see results being verified in either of ...
7 years, 3 months ago (2013-09-10 17:33:14 UTC) #4
Paul Lind
7 years, 3 months ago (2013-09-10 17:38:11 UTC) #5
On 2013/09/10 17:33:14, Paul Lind wrote:
> We could put this change behind a platform check, I suppose.

Oops, we will HAVE to do this, as the fix does not build on Mac, it is Linux
specific. Sorry for not checking this earlier.

Ákos, let's work this out, and upload a new patchset before we do further
reviews.

Powered by Google App Engine
This is Rietveld 408576698