Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2404883003:
[telemetry] Disable perf benchmarks that use BattOr tracing (Closed)
|
Created:
4 years, 2 months ago by charliea (OOO until 10-5) Modified:
4 years, 2 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, erikchen Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[telemetry] Disable perf benchmarks that use BattOr tracing
Unfortunately, with the current iteration of the BattOr firmware,
BattOr benchmarks are failing unless the SD cards on the BattOrs are
replaced on a daily basis. Mellow, the company that manufactures the
BattOrs, is working hard on a new version of the firmware that's more
stable, but in the meanwhile we're forced to disable the benchmarks on
all waterfalls where there's an expectation that tests won't fail
repeatedly.
BUG=652384
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/e8e1256d25b5f8c0bf706f2b21b9d86ac7e5356d
Cr-Commit-Position: refs/heads/master@{#424433}
Patch Set 1 #Patch Set 2 : Just disable enable_battor_trace on main waterfall #
Total comments: 1
Patch Set 3 : #
Messages
Total messages: 32 (17 generated)
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
charliea@chromium.org changed reviewers: + nednguyen@google.com
On 2016/10/10 18:55:55, charliea wrote: Why not just remove 'powerMetric', 'clockSyncLatencyMetric' & set enable_battor_trace to False for now? cpuTimeMetric is still valuable to keep track of.
Went ahead and did that. I didn't remove the powerMetric or clockSyncLatencyMetric, as they should just do the right thing: report the metric when possible, but do nothing when the data isn't available.
lgtm
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 ==========
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
https://codereview.chromium.org/2404883003/diff/20001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/2404883003/diff/20001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:30: os.environ['BUILDBOT_MASTERNAME'] == 'chromium.perf.fyi') you need to use os.environ.get(''BUILDBOT_MASTERNAME') which return None when the key doesn't exist
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2404883003/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Adding NOTRY=true because the Mac tryserver is failing.
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [telemetry] Disable perf benchmarks that use BattOr tracing Unfortunately, with the current iteration of the BattOr firmware, BattOr benchmarks are failing unless the SD cards on the BattOrs are replaced on a daily basis. Mellow, the company that manufactures the BattOrs, is working hard on a new version of the firmware that's more stable, but in the meanwhile we're forced to disable the benchmarks on all waterfalls where there's an expectation that tests won't fail repeatedly. BUG=652384 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/e8e1256d25b5f8c0bf706f2b21b9d86ac7e5356d Cr-Commit-Position: refs/heads/master@{#424433} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e8e1256d25b5f8c0bf706f2b21b9d86ac7e5356d Cr-Commit-Position: refs/heads/master@{#424433} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
