Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tools/perf/benchmarks/battor.py

Issue 2404883003: [telemetry] Disable perf benchmarks that use BattOr tracing (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/battor.py
diff --git a/tools/perf/benchmarks/battor.py b/tools/perf/benchmarks/battor.py
index a995dedfe5eaf3e24cda8bbe7d488fca8fd3d671..88f7d5211c92a570ee24be52f3dc8b2c59e8e703 100644
--- a/tools/perf/benchmarks/battor.py
+++ b/tools/perf/benchmarks/battor.py
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
+
from core import perf_benchmark
from telemetry.timeline import chrome_trace_category_filter
from telemetry.web_perf import timeline_based_measurement
@@ -21,7 +23,11 @@ class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
# TODO(charliea): Reenable the CPU tracing agent once it no longer causes
# indefinite hangs on Windows.
# https://crbug.com/647443
- options.config.enable_battor_trace = True
+ # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once
+ # the BattOrs stop crashing as their SD cards fill up.
+ # crbug.com/652384
+ options.config.enable_battor_trace = (
+ os.environ.get('BUILDBOT_MASTERNAME') == 'chromium.perf.fyi')
options.config.enable_chrome_trace = True
options.config.enable_atrace_trace = True
options.config.atrace_config.categories = ['sched']
@@ -114,7 +120,11 @@ class BattOrPowerCasesNoChromeTrace(_BattOrBenchmark):
def CreateTimelineBasedMeasurementOptions(self):
options = timeline_based_measurement.Options()
- options.config.enable_battor_trace = True
+ # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once
+ # the BattOrs stop crashing as their SD cards fill up.
+ # crbug.com/652384
+ options.config.enable_battor_trace = (
+ os.environ.get('BUILDBOT_MASTERNAME') == 'chromium.perf.fyi')
options.config.enable_chrome_trace = False
options.config.chrome_trace_config.SetDefaultOverheadFilter()
options.SetTimelineBasedMetrics(['powerMetric', 'clockSyncLatencyMetric'])
« no previous file with comments | « no previous file | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698