Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2404883003: [telemetry] Disable perf benchmarks that use BattOr tracing (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os
5 import re 6 import re
6 7
7 from core import perf_benchmark 8 from core import perf_benchmark
8 from telemetry import benchmark 9 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 10 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 11 from telemetry.web_perf import timeline_based_measurement
11 import page_sets 12 import page_sets
12 13
13 14
14 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames() 15 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
(...skipping 11 matching lines...) Expand all
26 1) Be rearchitected such that it doesn't. This is the most preferred option. 27 1) Be rearchitected such that it doesn't. This is the most preferred option.
27 2) Be run in a separate test suite (e.g. memory). 28 2) Be run in a separate test suite (e.g. memory).
28 29
29 https://goo.gl/Jek2NL. 30 https://goo.gl/Jek2NL.
30 """ 31 """
31 32
32 def CreateTimelineBasedMeasurementOptions(self): 33 def CreateTimelineBasedMeasurementOptions(self):
33 options = timeline_based_measurement.Options( 34 options = timeline_based_measurement.Options(
34 chrome_trace_category_filter.ChromeTraceCategoryFilter()) 35 chrome_trace_category_filter.ChromeTraceCategoryFilter())
35 options.config.chrome_trace_config.category_filter.AddFilterString('rail') 36 options.config.chrome_trace_config.category_filter.AddFilterString('rail')
36 options.config.enable_battor_trace = True 37 # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once
38 # the BattOrs stop crashing as their SD cards fill up.
39 # crbug.com/652384
40 options.config.enable_battor_trace = (
41 os.environ.get('BUILDBOT_MASTERNAME') == 'chromium.perf.fyi')
37 options.config.enable_chrome_trace = True 42 options.config.enable_chrome_trace = True
38 return options 43 return options
39 44
40 def CreateStorySet(self, options): 45 def CreateStorySet(self, options):
41 return page_sets.SystemHealthStorySet(platform=self.PLATFORM) 46 return page_sets.SystemHealthStorySet(platform=self.PLATFORM)
42 47
43 @classmethod 48 @classmethod
44 def ShouldTearDownStateAfterEachStoryRun(cls): 49 def ShouldTearDownStateAfterEachStoryRun(cls):
45 return True 50 return True
46 51
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 and load a blank page with multiprocess enabled. 187 and load a blank page with multiprocess enabled.
183 """ 188 """
184 189
185 def SetExtraBrowserOptions(self, options): 190 def SetExtraBrowserOptions(self, options):
186 options.AppendExtraBrowserArgs( 191 options.AppendExtraBrowserArgs(
187 ['--webview-sandboxed-renderer']) 192 ['--webview-sandboxed-renderer'])
188 193
189 @classmethod 194 @classmethod
190 def Name(cls): 195 def Name(cls):
191 return 'system_health.webview_startup_multiprocess' 196 return 'system_health.webview_startup_multiprocess'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698