Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2404883003: [telemetry] Disable perf benchmarks that use BattOr tracing (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 75862ea6200a45a1d08170a9e72728d9a5c160be..f3c7cc276ccff355b0079e3c8bfe43a86b9cfe4c 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
import re
from core import perf_benchmark
@@ -33,7 +34,11 @@ class _CommonSystemHealthBenchmark(perf_benchmark.PerfBenchmark):
options = timeline_based_measurement.Options(
chrome_trace_category_filter.ChromeTraceCategoryFilter())
options.config.chrome_trace_config.category_filter.AddFilterString('rail')
- options.config.enable_battor_trace = True
+ # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once
+ # the BattOrs stop crashing as their SD cards fill up.
+ # crbug.com/652384
+ options.config.enable_battor_trace = (
+ os.environ.get('BUILDBOT_MASTERNAME') == 'chromium.perf.fyi')
options.config.enable_chrome_trace = True
return options
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698