Compute and include the offset of the sticky box to its enclosing composited layer.

Compute and include the offset of the sticky box to its enclosing composited layer.

When the main thread moves a sticky object we try to determine how far it was moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer, ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/68e1c292942bc96e212048b7993500244a47dc41
Cr-Commit-Position: refs/heads/master@{#424451}

[flackr, 2016-10-07 13:30:06]

Description was changed from

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
==========

to

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[flackr, 2016-10-07 13:30:06]

Description was changed from

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[flackr, 2016-10-07 14:46:25]

flackr@chromium.org changed reviewers:
+ ajuma@chromium.org

[flackr, 2016-10-07 14:46:26]

Hey,

Can you take a look? This plumbs the offset from the sticky box to its enclosing
ancestor layer so that we know how much the main thread moved the sticky box.
This fixes the compositor position update where an intermediate element between
the sticky element and the scrolling ancestor is composited.

Thanks,
Rob

[flackr, 2016-10-07 18:20:50]

The CQ bit was checked by flackr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:21:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:35:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ajuma, 2016-10-07 21:14:42]

lgtm

https://codereview.chromium.org/2401903002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2401903002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:7196: // (0, 0) because we have
synced a scroll offset of (15, 15) from the main
(15, 15) should be (0, 25), right?

https://codereview.chromium.org/2401903002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right):

https://codereview.chromium.org/2401903002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:334:
registerMockedHttpURLLoad("sticky-position.html");
Did you forget to upload this file?

[flackr, 2016-10-09 13:19:15]

The CQ bit was checked by flackr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-09 13:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-09 13:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-09 13:26:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[flackr, 2016-10-11 03:53:18]

flackr@chromium.org changed reviewers:
+ rbyers@chromium.org

[flackr, 2016-10-11 03:53:19]

+rbyers for third_party/WebKit

https://codereview.chromium.org/2401903002/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2401903002/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:7196: // (0, 0) because we have
synced a scroll offset of (15, 15) from the main
On 2016/10/07 at 21:14:41, ajuma (OOO Oct. 10) wrote:
> (15, 15) should be (0, 25), right?

Right, forgot to update the comment.

[flackr, 2016-10-11 12:49:02]

https://codereview.chromium.org/2401903002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right):

https://codereview.chromium.org/2401903002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:334:
registerMockedHttpURLLoad("sticky-position.html");
On 2016/10/07 at 21:14:42, ajuma (OOO Oct. 10) wrote:
> Did you forget to upload this file?

I certainly did, it's added now.

[Rick Byers, 2016-10-11 15:04:32]

WebKit LGTM

[flackr, 2016-10-11 15:05:59]

The CQ bit was checked by flackr@chromium.org

[flackr, 2016-10-11 15:05:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2401903002/#ps40001
(title: "Merge with master and fix long line.")

[commit-bot: I haz the power, 2016-10-11 15:06:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:35:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 16:36:51]

Description was changed from

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Compute and include the offset of the sticky box to its enclosing composited
layer.

When the main thread moves a sticky object we try to determine how far it was
moved
in cc/ to know how much more we still have to move it. However, when the sticky
object is in a composited layer we need to know the expected offset from that
layer
rather than from the scroll ancestor.

BUG=649102
TEST=LayerTreeHostCommonTest.StickyPositionCompositedContainer,
ScrollingCoordinatorTest.fastScrollingForStickyPosition
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/68e1c292942bc96e212048b7993500244a47dc41
Cr-Commit-Position: refs/heads/master@{#424451}
==========

[commit-bot: I haz the power, 2016-10-11 16:36:52]

Patchset 3 (id:??) landed as
https://crrev.com/68e1c292942bc96e212048b7993500244a47dc41
Cr-Commit-Position: refs/heads/master@{#424451}