Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: cc/layers/layer.cc

Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer. (Closed)
Patch Set: Merge with master and fix long line. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer_sticky_position_constraint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index 9143d556f76e42e1189f9045d1e0c6c60fe89d30..43ad88a526794d27bb0563b93a9ea73d182b6970 100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -586,7 +586,7 @@ void Layer::SetPosition(const gfx::PointF& position) {
transform_tree_index());
sticky_data->main_thread_offset =
position.OffsetFromOrigin() -
- sticky_data->constraints.scroll_container_relative_sticky_box_rect
+ sticky_data->constraints.parent_relative_sticky_box_offset
.OffsetFromOrigin();
}
transform_node->needs_local_transform_update = true;
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer_sticky_position_constraint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698