Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: cc/blink/web_layer_impl.cc

Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer. (Closed)
Patch Set: Merge with master and fix long line. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_layer_impl.cc
diff --git a/cc/blink/web_layer_impl.cc b/cc/blink/web_layer_impl.cc
index a88fd3068c090f3909c2dfa3deb9ce5e436ffa40..ba40a266e7526a44cc380ca84568bb8aa6ac39cb 100644
--- a/cc/blink/web_layer_impl.cc
+++ b/cc/blink/web_layer_impl.cc
@@ -372,6 +372,8 @@ ToWebLayerStickyPositionConstraint(
web_constraint.rightOffset = constraint.right_offset;
web_constraint.topOffset = constraint.top_offset;
web_constraint.bottomOffset = constraint.bottom_offset;
+ web_constraint.parentRelativeStickyBoxOffset =
+ constraint.parent_relative_sticky_box_offset;
web_constraint.scrollContainerRelativeStickyBoxRect =
constraint.scroll_container_relative_sticky_box_rect;
web_constraint.scrollContainerRelativeContainingBlockRect =
@@ -390,6 +392,8 @@ static cc::LayerStickyPositionConstraint ToStickyPositionConstraint(
constraint.right_offset = web_constraint.rightOffset;
constraint.top_offset = web_constraint.topOffset;
constraint.bottom_offset = web_constraint.bottomOffset;
+ constraint.parent_relative_sticky_box_offset =
+ web_constraint.parentRelativeStickyBoxOffset;
constraint.scroll_container_relative_sticky_box_rect =
web_constraint.scrollContainerRelativeStickyBoxRect;
constraint.scroll_container_relative_containing_block_rect =
« no previous file with comments | « no previous file | cc/layers/layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698