cc/trees/property_tree_builder.cc - Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/property_tree_builder.cc

Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer. (Closed)

Patch Set: Merge with master and fix long line. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/property_tree_builder.cc

diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc

index edc102623e0f4d50260d61e4b7850fde76c12804..a8398bc55ecd84ca4b8d2b591ceb9e83a840fc88 100644

--- a/cc/trees/property_tree_builder.cc

+++ b/cc/trees/property_tree_builder.cc

@@ -699,7 +699,7 @@ bool AddTransformNodeIfNeeded(

sticky_data->scroll_ancestor = GetScrollParentId(data_from_ancestor, layer);

sticky_data->main_thread_offset =

layer->position().OffsetFromOrigin() -

- sticky_data->constraints.scroll_container_relative_sticky_box_rect

+ sticky_data->constraints.parent_relative_sticky_box_offset

.OffsetFromOrigin();

}