Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 240113009: Enable HW VAVDA by libva-wayland backend. (Closed)

Created:
6 years, 8 months ago by qing.zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable HW VAVDA by libva-wayland backend in ChromeOS. BUG=

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -153 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +9 lines, -2 lines 0 comments Download
A + content/common/gpu/media/va_wayland.sigs View 3 chunks +5 lines, -3 lines 0 comments Download
A + content/common/gpu/media/va_wayland_stub_header.fragment View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 4 chunks +15 lines, -2 lines 4 comments Download
A + content/common/gpu/media/vaapi_video_decode_accelerator_wayland.cc View 18 chunks +124 lines, -131 lines 1 comment Download
M content/common/gpu/media/vaapi_wrapper.h View 5 chunks +19 lines, -3 lines 1 comment Download
M content/common/gpu/media/vaapi_wrapper.cc View 8 chunks +82 lines, -7 lines 0 comments Download
M content/content_common.gypi View 1 chunk +26 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
qing.zhang
hi, fischman, Would you mind to help me to review this FIX. Thanks for your ...
6 years, 8 months ago (2014-04-17 02:25:00 UTC) #1
Ami GONE FROM CHROMIUM
I guess this is a continuation of https://codereview.chromium.org/43283002/ That CR left some questions unanswered; would ...
6 years, 8 months ago (2014-04-18 22:40:25 UTC) #2
qing.zhang
On 2014/04/18 22:40:25, Ami Fischman wrote: > I guess this is a continuation of https://codereview.chromium.org/43283002/ ...
6 years, 8 months ago (2014-04-19 10:08:14 UTC) #3
Ami GONE FROM CHROMIUM
On Sat, Apr 19, 2014 at 3:08 AM, <qing.zhang@intel.com> wrote: > Do you think this ...
6 years, 8 months ago (2014-04-19 15:55:26 UTC) #4
qing.zhang
On 2014/04/19 15:55:26, Ami Fischman wrote: > Not sure what you mean by "direction" but ...
6 years, 8 months ago (2014-04-20 02:00:01 UTC) #5
Ami GONE FROM CHROMIUM
On Sat, Apr 19, 2014 at 7:00 PM, <qing.zhang@intel.com> wrote: > On 2014/04/19 15:55:26, Ami ...
6 years, 8 months ago (2014-04-20 03:43:02 UTC) #6
chadv
This patch series makes Wayland a hard dependency when building Chromium OS without X11. That ...
6 years, 8 months ago (2014-04-21 20:46:03 UTC) #7
vignatti (out of this project)
6 years, 7 months ago (2014-05-05 23:18:31 UTC) #8
Message was sent while issue was closed.
On 2014/04/21 20:46:03, chad.versace wrote:
> This patch series makes Wayland a hard dependency when building Chromium OS
> without X11. That is the wrong direction for Chromium OS.
> 
> When Chromium OS migrates from X11 to the $NEW_THING, I do not want the
> NEW_THING to be Wayland. A better design is for Chromium OS to run directly on
> top KMS (also called GBM and DRI in this context).
> 
> Even Kristian Hogsberg himself, Wayland's creator, has told me the same many
> times.

FYI I also second that.

Powered by Google App Engine
This is Rietveld 408576698