Enable HW VAVDA by libva-wayland backend.

content/common/gpu/media/vaapi_video_decode_accelerator_wayland.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2014 and intel copyright. All rights reserved.

[Ami GONE FROM CHROMIUM, 2014/04/18 22:40:25]

Copyright rests with The Chromium Authors, not with contributing organizations. 
That's part of the CCLA/CLA.

Please revert this thunk.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/non_thread_safe.h"
 #include "content/common/gpu/gpu_channel.h"
 #include "content/common/gpu/media/vaapi_video_decode_accelerator.h"
 #include "media/base/bind_to_current_loop.h"
 #include "media/video/picture.h"
-#include "ui/gl/gl_bindings.h"
 #include "ui/gl/scoped_binders.h"
 
 static void ReportToUMA(
     content::VaapiH264Decoder::VAVDAH264DecoderFailure failure) {
   UMA_HISTOGRAM_ENUMERATION(
       "Media.VAVDAH264.DecoderFailure",
       failure,
       content::VaapiH264Decoder::VAVDA_H264_DECODER_FAILURES_MAX);
 }
 
@@ skipping 26 matching lines @@
   message_loop_->PostTask(FROM_HERE, base::Bind(
       &VaapiVideoDecodeAccelerator::Cleanup, weak_this_));
 
   DVLOG(1) << "Notifying of error " << error;
   if (client_) {
     client_->NotifyError(error);
     client_ptr_factory_.reset();
   }
 }
 
-// TFPPicture allocates X Pixmaps and binds them to textures passed
+// TFPPicture allocates VAImage and binds them to textures passed
 // in PictureBuffers from clients to them. TFPPictures are created as
 // a consequence of receiving a set of PictureBuffers from clients and released
 // at the end of decode (or when a new set of PictureBuffers is required).
 //
 // TFPPictures are used for output, contents of VASurfaces passed from decoder
-// are put into the associated pixmap memory and sent to client.
+// are put into the associated vaimage memory and upload to client.
 class VaapiVideoDecodeAccelerator::TFPPicture : public base::NonThreadSafe {
  public:
   ~TFPPicture();
 
   static linked_ptr<TFPPicture> Create(
-      const base::Callback<bool(void)>& make_context_current,
-      const GLXFBConfig& fb_config,
-      Display* x_display,
+      const base::Callback<bool(void)>& make_context_current, //NOLINT
+      wl_display* wl_display,
+      VaapiWrapper* va_wrapper,
       int32 picture_buffer_id,
       uint32 texture_id,
       gfx::Size size);
 
   int32 picture_buffer_id() {
     return picture_buffer_id_;
   }
 
   gfx::Size size() {
     return size_;
   }
 
-  int x_pixmap() {
-    return x_pixmap_;
-  }
-
-  // Bind texture to pixmap. Needs to be called every frame.
-  bool Bind();
+  // Upload vaimage data to texture. Needs to be called every frame.
+  bool Upload(VASurfaceID id);
 
  private:
-  TFPPicture(const base::Callback<bool(void)>& make_context_current,
-             Display* x_display,
+  TFPPicture(const base::Callback<bool(void)>& make_context_current, //NOLINT
+             wl_display* wl_display,
+             VaapiWrapper* va_wrapper,
              int32 picture_buffer_id,
              uint32 texture_id,
              gfx::Size size);
 
-  bool Initialize(const GLXFBConfig& fb_config);
+  bool Initialize();
 
-  base::Callback<bool(void)> make_context_current_;
+  base::Callback<bool(void)> make_context_current_; //NOLINT
 
-  Display* x_display_;
+  wl_display* wl_display_;
+  VaapiWrapper* va_wrapper_;
 
   // Output id for the client.
   int32 picture_buffer_id_;
   uint32 texture_id_;
 
   gfx::Size size_;
-
-  // Pixmaps bound to this texture.
-  Pixmap x_pixmap_;
-  GLXPixmap glx_pixmap_;
+  VAImage va_image_;
 
   DISALLOW_COPY_AND_ASSIGN(TFPPicture);
 };
 
 VaapiVideoDecodeAccelerator::TFPPicture::TFPPicture(
-    const base::Callback<bool(void)>& make_context_current,
-    Display* x_display,
+    const base::Callback<bool(void)>& make_context_current, //NOLINT
+    wl_display* wl_display,
+    VaapiWrapper* va_wrapper,
     int32 picture_buffer_id,
     uint32 texture_id,
     gfx::Size size)
     : make_context_current_(make_context_current),
-      x_display_(x_display),
+      wl_display_(wl_display),
+      va_wrapper_(va_wrapper),
       picture_buffer_id_(picture_buffer_id),
       texture_id_(texture_id),
-      size_(size),
-      x_pixmap_(0),
-      glx_pixmap_(0) {
+      size_(size) {
   DCHECK(!make_context_current_.is_null());
 };
 
 linked_ptr<VaapiVideoDecodeAccelerator::TFPPicture>
 VaapiVideoDecodeAccelerator::TFPPicture::Create(
-    const base::Callback<bool(void)>& make_context_current,
-    const GLXFBConfig& fb_config,
-    Display* x_display,
+    const base::Callback<bool(void)>& make_context_current, //NOLINT
+    wl_display* wl_display,
+    VaapiWrapper* va_wrapper,
     int32 picture_buffer_id,
     uint32 texture_id,
     gfx::Size size) {
+  linked_ptr<TFPPicture> tfp_picture(
+      new TFPPicture(make_context_current, wl_display, va_wrapper,
+                     picture_buffer_id, texture_id, size));
 
-  linked_ptr<TFPPicture> tfp_picture(
-      new TFPPicture(make_context_current, x_display, picture_buffer_id,
-                     texture_id, size));
-
-  if (!tfp_picture->Initialize(fb_config))
+  if (!tfp_picture->Initialize())
     tfp_picture.reset();
 
   return tfp_picture;
 }
 
-bool VaapiVideoDecodeAccelerator::TFPPicture::Initialize(
-    const GLXFBConfig& fb_config) {
+bool VaapiVideoDecodeAccelerator::TFPPicture::Initialize() {
   DCHECK(CalledOnValidThread());
   if (!make_context_current_.Run())
     return false;
 
-  XWindowAttributes win_attr;
-  int screen = DefaultScreen(x_display_);
-  XGetWindowAttributes(x_display_, RootWindow(x_display_, screen), &win_attr);
-  //TODO(posciak): pass the depth required by libva, not the RootWindow's depth
-  x_pixmap_ = XCreatePixmap(x_display_, RootWindow(x_display_, screen),
-                            size_.width(), size_.height(), win_attr.depth);
-  if (!x_pixmap_) {
-    DVLOG(1) << "Failed creating an X Pixmap for TFP";
+  if (!va_wrapper_->CreateRGBImage(size_, &va_image_)) {
+    DVLOG(1) << "Failed to create VAImage";
     return false;
   }
 
-  static const int pixmap_attr[] = {
-    GLX_TEXTURE_TARGET_EXT, GLX_TEXTURE_2D_EXT,
-    GLX_TEXTURE_FORMAT_EXT, GLX_TEXTURE_FORMAT_RGB_EXT,
-    GL_NONE,
-  };
-
-  glx_pixmap_ = glXCreatePixmap(x_display_, fb_config, x_pixmap_, pixmap_attr);
-  if (!glx_pixmap_) {
-    // x_pixmap_ will be freed in the destructor.
-    DVLOG(1) << "Failed creating a GLX Pixmap for TFP";
-    return false;
-  }
-
   return true;
 }
 
 VaapiVideoDecodeAccelerator::TFPPicture::~TFPPicture() {
   DCHECK(CalledOnValidThread());
-  // Unbind surface from texture and deallocate resources.
-  if (glx_pixmap_ && make_context_current_.Run()) {
-    glXReleaseTexImageEXT(x_display_, glx_pixmap_, GLX_FRONT_LEFT_EXT);
-    glXDestroyPixmap(x_display_, glx_pixmap_);
+
+  if (va_wrapper_) {
+    va_wrapper_->DestroyImage(&va_image_);
   }
-
-  if (x_pixmap_)
-    XFreePixmap(x_display_, x_pixmap_);
-  XSync(x_display_, False);  // Needed to work around buggy vdpau-driver.
 }
 
-bool VaapiVideoDecodeAccelerator::TFPPicture::Bind() {
+bool VaapiVideoDecodeAccelerator::TFPPicture::Upload(VASurfaceID surface) {
   DCHECK(CalledOnValidThread());
-  DCHECK(x_pixmap_);
-  DCHECK(glx_pixmap_);
+
   if (!make_context_current_.Run())
     return false;
 
+  if (!va_wrapper_->PutSurfaceIntoImage(surface, &va_image_)) {
+    DVLOG(1) << "Failed to put va surface to image";
+    return false;
+  }
+
+  void* buffer = NULL;
+  if (!va_wrapper_->MapImage(&va_image_, &buffer)) {
+    DVLOG(1) << "Failed to map VAImage";
+    return false;
+  }
+
   gfx::ScopedTextureBinder texture_binder(GL_TEXTURE_2D, texture_id_);
-  glXBindTexImageEXT(x_display_, glx_pixmap_, GLX_FRONT_LEFT_EXT, NULL);
+  glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+  glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+  glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, size_.width(), size_.height(),
+               0, GL_RGBA, GL_UNSIGNED_BYTE, buffer);
+
+  va_wrapper_->UnmapImage(&va_image_);
 
   return true;
 }
 
 VaapiVideoDecodeAccelerator::TFPPicture*
     VaapiVideoDecodeAccelerator::TFPPictureById(int32 picture_buffer_id) {
   TFPPictures::iterator it = tfp_pictures_.find(picture_buffer_id);
   if (it == tfp_pictures_.end()) {
     DVLOG(1) << "Picture id " << picture_buffer_id << " does not exist";
     return NULL;
   }
 
   return it->second.get();
 }
 
 VaapiVideoDecodeAccelerator::VaapiVideoDecodeAccelerator(
-    Display* x_display,
-    const base::Callback<bool(void)>& make_context_current)
-    : x_display_(x_display),
+    const base::Callback<bool(void)>& make_context_current) //NOLINT
+    : wl_display_(NULL),
       make_context_current_(make_context_current),
       state_(kUninitialized),
       input_ready_(&lock_),
       surfaces_available_(&lock_),
       message_loop_(base::MessageLoop::current()),
+      weak_this_(base::AsWeakPtr(this)),
+      va_surface_release_cb_(media::BindToCurrentLoop(base::Bind(
+          &VaapiVideoDecodeAccelerator::RecycleVASurfaceID, weak_this_))),
       decoder_thread_("VaapiDecoderThread"),
       num_frames_at_client_(0),
       num_stream_bufs_at_decoder_(0),
       finish_flush_pending_(false),
       awaiting_va_surfaces_recycle_(false),
-      requested_num_pics_(0),
-      weak_this_factory_(this) {
-  weak_this_ = weak_this_factory_.GetWeakPtr();
-  va_surface_release_cb_ = media::BindToCurrentLoop(
-      base::Bind(&VaapiVideoDecodeAccelerator::RecycleVASurfaceID, weak_this_));
+      requested_num_pics_(0) {
 }
 
 VaapiVideoDecodeAccelerator::~VaapiVideoDecodeAccelerator() {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
+  if (wl_display_) {
+    wl_display_flush(wl_display_);
+    wl_display_disconnect(wl_display_);
+    wl_display_ = NULL;
+  }
 }
 
-class XFreeDeleter {
- public:
-  void operator()(void* x) const {
-    ::XFree(x);
+typedef struct wayland_display {
+  wl_display* display;
+  wl_compositor* compositor;
+  wl_shell* shell;
+  wl_registry* registry;
+  int event_fd;
+} wayland_display;
+
+static void registry_handle_global(
+    void* data,
+    wl_registry* registry,
+    uint32_t id,
+    const char* interface,
+    uint32_t version) {
+  wayland_display* display_handle =
+      reinterpret_cast<wayland_display *>(data);
+
+  if (strcmp(interface, "wl_compositor") == 0) {
+    display_handle->compositor =
+        reinterpret_cast<wl_compositor *>(wl_registry_bind(
+            registry, id, &wl_compositor_interface, 1));
+  } else if (strcmp(interface, "wl_shell") == 0) {
+    display_handle->shell =
+        reinterpret_cast<wl_shell *>(wl_registry_bind(
+            registry, id, &wl_shell_interface, 1));
   }
+}
+
+static const struct wl_registry_listener registry_listener = {
+  registry_handle_global,
+  NULL,
 };
 
-bool VaapiVideoDecodeAccelerator::InitializeFBConfig() {
-  const int fbconfig_attr[] = {
-    GLX_DRAWABLE_TYPE, GLX_PIXMAP_BIT,
-    GLX_BIND_TO_TEXTURE_TARGETS_EXT, GLX_TEXTURE_2D_BIT_EXT,
-    GLX_BIND_TO_TEXTURE_RGB_EXT, GL_TRUE,
-    GLX_Y_INVERTED_EXT, GL_TRUE,
-    GL_NONE,
-  };
-
-  int num_fbconfigs;
-  scoped_ptr<GLXFBConfig, XFreeDeleter> glx_fb_configs(
-      glXChooseFBConfig(x_display_, DefaultScreen(x_display_), fbconfig_attr,
-                        &num_fbconfigs));
-  if (!glx_fb_configs)
-    return false;
-  if (!num_fbconfigs)
-    return false;
-
-  fb_config_ = glx_fb_configs.get()[0];
-  return true;
-}
-
 bool VaapiVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile,
                                              Client* client) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
 
   client_ptr_factory_.reset(new base::WeakPtrFactory<Client>(client));
   client_ = client_ptr_factory_->GetWeakPtr();
 
   base::AutoLock auto_lock(lock_);
   DCHECK_EQ(state_, kUninitialized);
   DVLOG(2) << "Initializing VAVDA, profile: " << profile;
 
   if (!make_context_current_.Run())
     return false;
 
-  if (!InitializeFBConfig()) {
-    DVLOG(1) << "Could not get a usable FBConfig";
+  wayland_display d;
+
+  d.display = wl_display_connect(NULL);
+  if (!d.display)
     return false;
-  }
+  wl_display_set_user_data(d.display, &d);
+  d.registry = wl_display_get_registry(d.display);
+  wl_registry_add_listener(d.registry, &registry_listener, &d);
+  wl_display_dispatch(d.display);
+  wl_display_ = d.display;
 
   vaapi_wrapper_ = VaapiWrapper::Create(
-      profile, x_display_,
+      profile, wl_display_,
       base::Bind(&ReportToUMA, content::VaapiH264Decoder::VAAPI_ERROR));
 
   if (!vaapi_wrapper_.get()) {
     DVLOG(1) << "Failed initializing VAAPI";
     return false;
   }
 
   decoder_.reset(
       new VaapiH264Decoder(
           vaapi_wrapper_.get(),
           media::BindToCurrentLoop(base::Bind(
               &VaapiVideoDecodeAccelerator::SurfaceReady, weak_this_)),
           base::Bind(&ReportToUMA)));
 
   CHECK(decoder_thread_.Start());
   decoder_thread_proxy_ = decoder_thread_.message_loop_proxy();
 
   state_ = kIdle;
+
+  message_loop_->PostTask(FROM_HERE, base::Bind(
+      &Client::NotifyInitializeDone, client_));
+
   return true;
 }
 
 void VaapiVideoDecodeAccelerator::SurfaceReady(
     int32 input_id,
     const scoped_refptr<VASurface>& va_surface) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
   DCHECK(!awaiting_va_surfaces_recycle_);
 
   // Drop any requests to output if we are resetting or being destroyed.
@@ skipping 15 matching lines @@
 
   int32 output_id  = tfp_picture->picture_buffer_id();
 
   TRACE_EVENT2("Video Decoder", "VAVDA::OutputSurface",
                "input_id", input_id,
                "output_id", output_id);
 
   DVLOG(3) << "Outputting VASurface " << va_surface->id()
            << " into pixmap bound to picture buffer id " << output_id;
 
-  RETURN_AND_NOTIFY_ON_FAILURE(tfp_picture->Bind(),
-                               "Failed binding texture to pixmap",
-                               PLATFORM_FAILURE, );
-
-  RETURN_AND_NOTIFY_ON_FAILURE(
-      vaapi_wrapper_->PutSurfaceIntoPixmap(va_surface->id(),
-                                           tfp_picture->x_pixmap(),
-                                           tfp_picture->size()),
-      "Failed putting surface into pixmap", PLATFORM_FAILURE, );
+  RETURN_AND_NOTIFY_ON_FAILURE(tfp_picture->Upload(va_surface->id()),
+                               "Failed to upload VASurface to texture",
+                               PLATFORM_FAILURE, ); //NOLINT
 
   // Notify the client a picture is ready to be displayed.
   ++num_frames_at_client_;
   TRACE_COUNTER1("Video Decoder", "Textures at client", num_frames_at_client_);
   DVLOG(4) << "Notifying output picture id " << output_id
            << " for input "<< input_id << " is ready";
   if (client_)
     client_->PictureReady(media::Picture(output_id, input_id));
 }
 
@@ skipping 20 matching lines @@
     FinishFlush();
 }
 
 void VaapiVideoDecodeAccelerator::MapAndQueueNewInputBuffer(
     const media::BitstreamBuffer& bitstream_buffer) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
   TRACE_EVENT1("Video Decoder", "MapAndQueueNewInputBuffer", "input_id",
       bitstream_buffer.id());
 
   DVLOG(4) << "Mapping new input buffer id: " << bitstream_buffer.id()
-           << " size: " << (int)bitstream_buffer.size();
+           << " size: " << static_cast<int>(bitstream_buffer.size());
 
   scoped_ptr<base::SharedMemory> shm(
       new base::SharedMemory(bitstream_buffer.handle(), true));
   RETURN_AND_NOTIFY_ON_FAILURE(shm->Map(bitstream_buffer.size()),
-                              "Failed to map input buffer", UNREADABLE_INPUT,);
+      "Failed to map input buffer", UNREADABLE_INPUT,); //NOLINT
 
   base::AutoLock auto_lock(lock_);
 
   // Set up a new input buffer and queue it for later.
   linked_ptr<InputBuffer> input_buffer(new InputBuffer());
   input_buffer->shm.reset(shm.release());
   input_buffer->id = bitstream_buffer.id();
   input_buffer->size = bitstream_buffer.size();
 
   ++num_stream_bufs_at_decoder_;
@@ skipping 63 matching lines @@
   --num_stream_bufs_at_decoder_;
   TRACE_COUNTER1("Video Decoder", "Stream buffers at decoder",
                  num_stream_bufs_at_decoder_);
 }
 
 bool VaapiVideoDecodeAccelerator::FeedDecoderWithOutputSurfaces_Locked() {
   lock_.AssertAcquired();
   DCHECK(decoder_thread_proxy_->BelongsToCurrentThread());
 
   while (available_va_surfaces_.empty() &&
-         (state_ == kDecoding || state_ == kFlushing || state_ == kIdle)) {
+        (state_ == kDecoding || state_ == kFlushing || state_ == kIdle)) {
     surfaces_available_.Wait();
   }
 
   if (state_ != kDecoding && state_ != kFlushing && state_ != kIdle)
     return false;
 
   while (!available_va_surfaces_.empty()) {
     scoped_refptr<VASurface> va_surface(
         new VASurface(available_va_surfaces_.front(), va_surface_release_cb_));
     available_va_surfaces_.pop_front();
@@ skipping 47 matching lines @@
       case VaapiH264Decoder::kRanOutOfSurfaces:
         // No more output buffers in the decoder, try getting more or go to
         // sleep waiting for them.
         if (!FeedDecoderWithOutputSurfaces_Locked())
           return;
 
         break;
 
       case VaapiH264Decoder::kDecodeError:
         RETURN_AND_NOTIFY_ON_FAILURE(false, "Error decoding stream",
-                                     PLATFORM_FAILURE, );
+                                     PLATFORM_FAILURE,); //NOLINT
         return;
     }
   }
 }
 
 void VaapiVideoDecodeAccelerator::InitiateSurfaceSetChange(size_t num_pics,
                                                            gfx::Size size) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
   DCHECK(!awaiting_va_surfaces_recycle_);
 
@@ skipping 77 matching lines @@
       // Decoder already running, fallthrough.
     case kResetting:
       // When resetting, allow accumulating bitstream buffers, so that
       // the client can queue after-seek-buffers while we are finishing with
       // the before-seek one.
       break;
 
     default:
       RETURN_AND_NOTIFY_ON_FAILURE(false,
           "Decode request from client in invalid state: " << state_,
-          PLATFORM_FAILURE, );
+          PLATFORM_FAILURE,); //NOLINT
       break;
   }
 }
 
 void VaapiVideoDecodeAccelerator::RecycleVASurfaceID(
     VASurfaceID va_surface_id) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
   base::AutoLock auto_lock(lock_);
 
   available_va_surfaces_.push_back(va_surface_id);
   surfaces_available_.Signal();
 }
 
 void VaapiVideoDecodeAccelerator::AssignPictureBuffers(
     const std::vector<media::PictureBuffer>& buffers) {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
 
   base::AutoLock auto_lock(lock_);
   DCHECK(tfp_pictures_.empty());
 
   while (!output_buffers_.empty())
     output_buffers_.pop();
 
   RETURN_AND_NOTIFY_ON_FAILURE(
       buffers.size() == requested_num_pics_,
-      "Got an invalid number of picture buffers. (Got " << buffers.size()
-      << ", requested " << requested_num_pics_ << ")", INVALID_ARGUMENT, );
+      "Got an invalid buffers. (Got " << buffers.size() << ", requested "
+      << requested_num_pics_ << ")", INVALID_ARGUMENT,); //NOLINT
   DCHECK(requested_pic_size_ == buffers[0].size());
 
   std::vector<VASurfaceID> va_surface_ids;
   RETURN_AND_NOTIFY_ON_FAILURE(
       vaapi_wrapper_->CreateSurfaces(requested_pic_size_,
                                      buffers.size(),
                                      &va_surface_ids),
-      "Failed creating VA Surfaces", PLATFORM_FAILURE, );
+      "Failed creating VA Surfaces", PLATFORM_FAILURE,); //NOLINT
   DCHECK_EQ(va_surface_ids.size(), buffers.size());
 
   for (size_t i = 0; i < buffers.size(); ++i) {
     DVLOG(2) << "Assigning picture id: " << buffers[i].id()
              << " to texture id: " << buffers[i].texture_id()
              << " VASurfaceID: " << va_surface_ids[i];
 
     linked_ptr<TFPPicture> tfp_picture(
-        TFPPicture::Create(make_context_current_, fb_config_, x_display_,
-                           buffers[i].id(), buffers[i].texture_id(),
-                           requested_pic_size_));
+        TFPPicture::Create(make_context_current_, wl_display_,
+                           vaapi_wrapper_.get(), buffers[i].id(),
+                           buffers[i].texture_id(), requested_pic_size_));
 
     RETURN_AND_NOTIFY_ON_FAILURE(
         tfp_picture.get(), "Failed assigning picture buffer to a texture.",
-        PLATFORM_FAILURE, );
+        PLATFORM_FAILURE,); //NOLINT
 
     bool inserted = tfp_pictures_.insert(std::make_pair(
         buffers[i].id(), tfp_picture)).second;
     DCHECK(inserted);
 
     output_buffers_.push(buffers[i].id());
     available_va_surfaces_.push_back(va_surface_ids[i]);
     surfaces_available_.Signal();
   }
 
@@ skipping 15 matching lines @@
 }
 
 void VaapiVideoDecodeAccelerator::FlushTask() {
   DCHECK(decoder_thread_proxy_->BelongsToCurrentThread());
   DVLOG(1) << "Flush task";
 
   // First flush all the pictures that haven't been outputted, notifying the
   // client to output them.
   bool res = decoder_->Flush();
   RETURN_AND_NOTIFY_ON_FAILURE(res, "Failed flushing the decoder.",
-                               PLATFORM_FAILURE, );
+                               PLATFORM_FAILURE,); //NOLINT
 
   // Put the decoder in idle state, ready to resume.
   decoder_->Reset();
 
   message_loop_->PostTask(FROM_HERE, base::Bind(
       &VaapiVideoDecodeAccelerator::FinishFlush, weak_this_));
 }
 
 void VaapiVideoDecodeAccelerator::Flush() {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
@@ skipping 128 matching lines @@
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
 
   if (state_ == kUninitialized || state_ == kDestroying)
     return;
 
   DVLOG(1) << "Destroying VAVDA";
   base::AutoLock auto_lock(lock_);
   state_ = kDestroying;
 
   client_ptr_factory_.reset();
-  weak_this_factory_.InvalidateWeakPtrs();
 
   {
     base::AutoUnlock auto_unlock(lock_);
     // Post a dummy task to the decoder_thread_ to ensure it is drained.
     base::WaitableEvent waiter(false, false);
     decoder_thread_proxy_->PostTask(FROM_HERE, base::Bind(
         &base::WaitableEvent::Signal, base::Unretained(&waiter)));
     input_ready_.Signal();
     surfaces_available_.Signal();
     waiter.Wait();
     decoder_thread_.Stop();
   }
 
   state_ = kUninitialized;
 }
 
 void VaapiVideoDecodeAccelerator::Destroy() {
   DCHECK_EQ(message_loop_, base::MessageLoop::current());
   Cleanup();
   delete this;
 }
 
 }  // namespace content