[Signin] Update sign in promo triggering logic

[Signin] Update sign in promo triggering logic

BUG=626425
Committed: https://crrev.com/b37cd1804ccbc810f8e0d475c9ea658a3ccd4479
Cr-Commit-Position: refs/heads/master@{#424087}

[gogerald1, 2016-10-06 20:13:38]

Description was changed from

==========
remove unused headers


update sign in promo triggering logic


draft

BUG=
==========

to

==========
[Signin] Update sign in promo triggering logic

BUG=
==========

[gogerald1, 2016-10-06 20:28:41]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-06 20:30:36]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:30:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-06 20:31:23]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-06 20:31:30]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2016-10-06 20:31:37]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2016-10-06 20:51:32]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:51:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-06 20:52:41]

Patchset #1 (id:60001) has been deleted

[gogerald1, 2016-10-06 20:54:56]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2016-10-06 20:55:05]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-10-06 20:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-06 20:55:43]

Description was changed from

==========
[Signin] Update sign in promo triggering logic

BUG=
==========

to

==========
[Signin] Update sign in promo triggering logic

BUG=626425
==========

[commit-bot: I haz the power, 2016-10-06 21:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:31:29]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-06 22:34:20]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 22:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-06 22:37:17]

Patchset #1 (id:100001) has been deleted

[gogerald1, 2016-10-06 22:41:59]

gogerald@chromium.org changed reviewers:
+ bauerb@chromium.org

[gogerald1, 2016-10-06 22:42:00]

Hi, PTAL,

[commit-bot: I haz the power, 2016-10-06 23:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:14:30]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-07 09:16:26]

https://codereview.chromium.org/2400793003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
(right):

https://codereview.chromium.org/2400793003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java:188:
Integer.parseInt(currentVersion.substring(0, currentVersion.indexOf('.')), 10);
Hm... in principle you could put the major version directly into
chrome/android/java/ChromeVersionConstants.java.version instead of parsing it
from the full string.

[gogerald1, 2016-10-07 14:59:55]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:00:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-07 15:03:45]

https://codereview.chromium.org/2400793003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
(right):

https://codereview.chromium.org/2400793003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java:188:
Integer.parseInt(currentVersion.substring(0, currentVersion.indexOf('.')), 10);
On 2016/10/07 09:16:25, Bernhard Bauer wrote:
> Hm... in principle you could put the major version directly into
> chrome/android/java/ChromeVersionConstants.java.version instead of parsing it
> from the full string.

Done. used to have a little bit hesitation to introduce new interface and space
for a simple usage :-)

[commit-bot: I haz the power, 2016-10-07 15:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:29:11]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-07 16:17:23]

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
File chrome/android/java/ChromeVersionConstants.java.version (right):

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
chrome/android/java/ChromeVersionConstants.java.version:10: static final String
PRODUCT_MAJOR_VERSION = "@MAJOR@";
I think you can make this directly an int :)

[gogerald1, 2016-10-07 17:45:41]

Patchset #3 (id:160001) has been deleted

[gogerald1, 2016-10-07 17:48:10]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 17:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-07 17:51:10]

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
File chrome/android/java/ChromeVersionConstants.java.version (right):

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
chrome/android/java/ChromeVersionConstants.java.version:10: static final String
PRODUCT_MAJOR_VERSION = "@MAJOR@";
On 2016/10/07 16:17:23, Bernhard Bauer wrote:
> I think you can make this directly an int :)

Done. It looks inconsistent for getProductVersion and getProductMajorVersion
return two different types of data.

[commit-bot: I haz the power, 2016-10-07 18:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:21:00]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-08 13:54:51]

Thanks, LGTM!

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
File chrome/android/java/ChromeVersionConstants.java.version (right):

https://codereview.chromium.org/2400793003/diff/140001/chrome/android/java/Ch...
chrome/android/java/ChromeVersionConstants.java.version:10: static final String
PRODUCT_MAJOR_VERSION = "@MAJOR@";
On 2016/10/07 17:51:09, gogerald1 wrote:
> On 2016/10/07 16:17:23, Bernhard Bauer wrote:
> > I think you can make this directly an int :)
> 
> Done. It looks inconsistent for getProductVersion and getProductMajorVersion
> return two different types of data.

Eh :) The latter is meant to be numeric, and the former obviously can't be, so I
don't think it's that inconsistent.

[gogerald1, 2016-10-08 19:59:04]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-08 19:59:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 20:28:51]

Description was changed from

==========
[Signin] Update sign in promo triggering logic

BUG=626425
==========

to

==========
[Signin] Update sign in promo triggering logic

BUG=626425
==========

[commit-bot: I haz the power, 2016-10-08 20:28:52]

Committed patchset #3 (id:180001)

[commit-bot: I haz the power, 2016-10-08 20:30:40]

Description was changed from

==========
[Signin] Update sign in promo triggering logic

BUG=626425
==========

to

==========
[Signin] Update sign in promo triggering logic

BUG=626425

Committed: https://crrev.com/b37cd1804ccbc810f8e0d475c9ea658a3ccd4479
Cr-Commit-Position: refs/heads/master@{#424087}
==========

[commit-bot: I haz the power, 2016-10-08 20:30:41]

Patchset 3 (id:??) landed as
https://crrev.com/b37cd1804ccbc810f8e0d475c9ea658a3ccd4479
Cr-Commit-Position: refs/heads/master@{#424087}