chrome/android/java/ChromeVersionConstants.java.version - Issue 2400793003: [Signin] Update sign in promo triggering logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/ChromeVersionConstants.java.version

Issue 2400793003: [Signin] Update sign in promo triggering logic (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.chrome.browser;	5 package org.chromium.chrome.browser;

6	6

7 class ChromeVersionConstants {	7 class ChromeVersionConstants {

8 static final String PRODUCT_NAME = "@PRODUCT_FULLNAME@";	8 static final String PRODUCT_NAME = "@PRODUCT_FULLNAME@";

9 static final String PRODUCT_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@";	9 static final String PRODUCT_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@";

	10 static final String PRODUCT_MAJOR_VERSION = "@MAJOR@";
	Bernhard Bauer 2016/10/07 16:17:23 I think you can make this directly an int :) I think you can make this directly an int :) gogerald1 2016/10/07 17:51:09 Done. It looks inconsistent for getProductVersion Show quoted text On 2016/10/07 16:17:23, Bernhard Bauer wrote: > I think you can make this directly an int :) Done. It looks inconsistent for getProductVersion and getProductMajorVersion return two different types of data. Bernhard Bauer 2016/10/08 13:54:51 Eh :) The latter is meant to be numeric, and the f Show quoted text On 2016/10/07 17:51:09, gogerald1 wrote: > On 2016/10/07 16:17:23, Bernhard Bauer wrote: > > I think you can make this directly an int :) > > Done. It looks inconsistent for getProductVersion and getProductMajorVersion > return two different types of data. Eh :) The latter is meant to be numeric, and the former obviously can't be, so I don't think it's that inconsistent.
10 static final boolean IS_OFFICIAL_BUILD = @OFFICIAL_BUILD@ == 1;	11 static final boolean IS_OFFICIAL_BUILD = @OFFICIAL_BUILD@ == 1;

11	12

12 static final int CHANNEL_DEFAULT = 0;	13 static final int CHANNEL_DEFAULT = 0;

13 static final int CHANNEL_CANARY = 1;	14 static final int CHANNEL_CANARY = 1;

14 static final int CHANNEL_DEV = 2;	15 static final int CHANNEL_DEV = 2;

15 static final int CHANNEL_BETA = 3;	16 static final int CHANNEL_BETA = 3;

16 static final int CHANNEL_STABLE = 4;	17 static final int CHANNEL_STABLE = 4;

17 static final int CHANNEL_WORK = 5;	18 static final int CHANNEL_WORK = 5;

18 static final int CHANNEL = CHANNEL_@CHANNEL@;	19 static final int CHANNEL = CHANNEL_@CHANNEL@;

19 }	20 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »