chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2400793003: [Signin] Update sign in promo triggering logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2400793003: [Signin] Update sign in promo triggering logic (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/ChromeVersionConstants.java.version ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 6457414618b720def4d39a752b338eae557625bb..8637516387f30f527bebc329b055b9f3f8e37654 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -358,6 +358,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

launchFirstRunExperience();

+ refreshSignIn();

ChromePreferenceManager preferenceManager = ChromePreferenceManager.getInstance(this);

// Promos can only be shown when we start with ACTION_MAIN intent and

// after FRE is complete.

@@ -375,8 +377,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

}

- refreshSignIn();

initializeUI();

// The dataset has already been created, we need to initialize our state.