chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java - Issue 2400793003: [Signin] Update sign in promo triggering logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

Issue 2400793003: [Signin] Update sign in promo triggering logic (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

index 6b40fc6157c59a1f92198b0a4b4d4d7e8a102439..8406e25f7bbfa6ae8745265144b8e31e0421db8f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

@@ -39,7 +39,7 @@ public class SigninPromoUtil {

return false;

}

- AccountSigninActivity.startAccountSigninActivity(activity, SigninAccessPoint.SIGNIN_PROMO);

+ AccountSigninActivity.startIfAllowed(activity, SigninAccessPoint.SIGNIN_PROMO);

preferenceManager.setSigninPromoShown();

return true;

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java ('k') | no next file » | no next file with comments »