Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2400783002: Reformat comments in core/layout/svg (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, rwlbuis, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, fs, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat comments in core/layout/svg BUG=563793 R=pdr@chromium.org Committed: https://crrev.com/a72b163a4b9ba97742a7cb442e4c566ec9c6c909 Cr-Commit-Position: refs/heads/master@{#423696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -261 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 chunk +18 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 5 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 6 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 4 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp View 4 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 9 chunks +45 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 5 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 13 chunks +47 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 7 chunks +22 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 1 chunk +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.h View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 7 chunks +22 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
eae
4 years, 2 months ago (2016-10-06 19:46:10 UTC) #1
pdr.
On 2016/10/06 at 19:46:10, eae wrote: > LGTM, thanks!
4 years, 2 months ago (2016-10-06 19:50:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400783002/1
4 years, 2 months ago (2016-10-06 21:36:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:44:12 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:47:24 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a72b163a4b9ba97742a7cb442e4c566ec9c6c909
Cr-Commit-Position: refs/heads/master@{#423696}

Powered by Google App Engine
This is Rietveld 408576698