Use BoringSSL scopers in //net.

Use BoringSSL scopers in //net.

BUG=654143
Committed: https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d
Cr-Commit-Position: refs/heads/master@{#424298}

[davidben, 2016-10-08 00:22:41]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 00:23:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 00:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 00:37:05]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[davidben, 2016-10-08 05:41:18]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 05:41:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-10-08 06:19:25]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2016-10-08 06:19:29]

davidben@chromium.org changed reviewers:
+ eroman@chromium.org, rch@chromium.org

[davidben, 2016-10-08 06:19:30]

rch for net/quic
eroman for everything else

[commit-bot: I haz the power, 2016-10-08 06:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 07:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 07:16:49]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-10-09 20:29:02]

net/quic/ LGTM

[eroman, 2016-10-10 22:45:55]

lgtm!

https://codereview.chromium.org/2400033005/diff/50001/net/base/keygen_handler...
File net/base/keygen_handler_unittest.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/base/keygen_handler...
net/base/keygen_handler_unittest.cc:157: bssl::ScopedEVP_MD_CTX ctx;
Nice that these are stack allocated now!

https://codereview.chromium.org/2400033005/diff/50001/net/cert/cert_verify_pr...
File net/cert/cert_verify_proc_openssl.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/cert_verify_pr...
net/cert/cert_verify_proc_openssl.cc:92: struct ShallowX509Stack {
Can you add "Deleter" in the name?

https://codereview.chromium.org/2400033005/diff/50001/net/cert/internal/verif...
File net/cert/internal/verify_signed_data.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/internal/verif...
net/cert/internal/verify_signed_data.cc:164: RSA* rsa =
EVP_PKEY_get0_RSA(pkey->get());
Thanks for removing the spurious refcounts in this file.

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
File net/cert/x509_certificate_ios.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
net/cert/x509_certificate_ios.cc:386: bssl::UniquePtr<STACK_OF(X509_NAME)>
issuer_names(sk_X509_NAME_new_null());
The STACK_OF() stuff is kind of inscrutable to me.
I will take your word for now that this is an exact translation, and check this
after I educate myself more...

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
File net/cert/x509_certificate_openssl.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
net/cert/x509_certificate_openssl.cc:388: bssl::UniquePtr<STACK_OF(X509_NAME)>
issuer_names(sk_X509_NAME_new_null());
same here.

https://codereview.chromium.org/2400033005/diff/50001/net/quic/core/crypto/p2...
File net/quic/core/crypto/p256_key_exchange.h (right):

https://codereview.chromium.org/2400033005/diff/50001/net/quic/core/crypto/p2...
net/quic/core/crypto/p256_key_exchange.h:59: P256KeyExchange(EC_KEY*
private_key, const uint8_t* public_key);
side-comment: based on this description sounds like |private_key| wants to be a
bssl::UniquePtr<EC_KEY> ...

[davidben, 2016-10-10 23:24:40]

https://codereview.chromium.org/2400033005/diff/50001/net/cert/cert_verify_pr...
File net/cert/cert_verify_proc_openssl.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/cert_verify_pr...
net/cert/cert_verify_proc_openssl.cc:92: struct ShallowX509Stack {
On 2016/10/10 22:45:54, eroman wrote:
> Can you add "Deleter" in the name?

Done.

PS: I'm pretty sure nothing builds this file. :-)

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
File net/cert/x509_certificate_ios.cc (right):

https://codereview.chromium.org/2400033005/diff/50001/net/cert/x509_certifica...
net/cert/x509_certificate_ios.cc:386: bssl::UniquePtr<STACK_OF(X509_NAME)>
issuer_names(sk_X509_NAME_new_null());
On 2016/10/10 22:45:55, eroman wrote:
> The STACK_OF() stuff is kind of inscrutable to me.
> I will take your word for now that this is an exact translation, and check
this
> after I educate myself more...

Fake C templates. :-) You can basically pretend it says STACK_OF<X509_NAME>.
Unfortunately OpenSSL doesn't distinguish between the moral equivalent of
std::vector<bssl::UniquePtr<X509_NAME>> and std::vector<X509_NAME*>. The scopers
assume you want the former.

https://codereview.chromium.org/2400033005/diff/50001/net/quic/core/crypto/p2...
File net/quic/core/crypto/p256_key_exchange.h (right):

https://codereview.chromium.org/2400033005/diff/50001/net/quic/core/crypto/p2...
net/quic/core/crypto/p256_key_exchange.h:59: P256KeyExchange(EC_KEY*
private_key, const uint8_t* public_key);
On 2016/10/10 22:45:55, eroman wrote:
> side-comment: based on this description sounds like |private_key| wants to be
a
> bssl::UniquePtr<EC_KEY> ...

You're right. Fixed.

[davidben, 2016-10-10 23:24:48]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-10-10 23:24:48]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2400033005/#ps70001
(title: "eroman comments")

[commit-bot: I haz the power, 2016-10-10 23:25:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 00:14:12]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-10-11 00:19:49]

Description was changed from

==========
Use BoringSSL scopers in //net.

BUG=654143
==========

to

==========
Use BoringSSL scopers in //net.

BUG=654143

Committed: https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d
Cr-Commit-Position: refs/heads/master@{#424298}
==========

[commit-bot: I haz the power, 2016-10-11 00:19:51]

Patchset 5 (id:??) landed as
https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d
Cr-Commit-Position: refs/heads/master@{#424298}