Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: net/quic/core/crypto/p256_key_exchange.cc

Issue 2400033005: Use BoringSSL scopers in //net. (Closed)
Patch Set: eroman comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/crypto/p256_key_exchange.h ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/crypto/p256_key_exchange.h" 5 #include "net/quic/core/crypto/p256_key_exchange.h"
6 6
7 #include <openssl/ec.h> 7 #include <openssl/ec.h>
8 #include <openssl/ecdh.h> 8 #include <openssl/ecdh.h>
9 #include <openssl/evp.h> 9 #include <openssl/evp.h>
10 10
11 #include <utility>
12
11 #include "base/logging.h" 13 #include "base/logging.h"
12 14
13 using base::StringPiece; 15 using base::StringPiece;
14 using std::string; 16 using std::string;
15 17
16 namespace net { 18 namespace net {
17 19
18 P256KeyExchange::P256KeyExchange(EC_KEY* private_key, const uint8_t* public_key) 20 P256KeyExchange::P256KeyExchange(bssl::UniquePtr<EC_KEY> private_key,
19 : private_key_(private_key) { 21 const uint8_t* public_key)
22 : private_key_(std::move(private_key)) {
20 memcpy(public_key_, public_key, sizeof(public_key_)); 23 memcpy(public_key_, public_key, sizeof(public_key_));
21 } 24 }
22 25
23 P256KeyExchange::~P256KeyExchange() {} 26 P256KeyExchange::~P256KeyExchange() {}
24 27
25 // static 28 // static
26 P256KeyExchange* P256KeyExchange::New(StringPiece key) { 29 P256KeyExchange* P256KeyExchange::New(StringPiece key) {
27 if (key.empty()) { 30 if (key.empty()) {
28 DVLOG(1) << "Private key is empty"; 31 DVLOG(1) << "Private key is empty";
29 return nullptr; 32 return nullptr;
30 } 33 }
31 34
32 const uint8_t* keyp = reinterpret_cast<const uint8_t*>(key.data()); 35 const uint8_t* keyp = reinterpret_cast<const uint8_t*>(key.data());
33 crypto::ScopedEC_KEY private_key( 36 bssl::UniquePtr<EC_KEY> private_key(
34 d2i_ECPrivateKey(nullptr, &keyp, key.size())); 37 d2i_ECPrivateKey(nullptr, &keyp, key.size()));
35 if (!private_key.get() || !EC_KEY_check_key(private_key.get())) { 38 if (!private_key.get() || !EC_KEY_check_key(private_key.get())) {
36 DVLOG(1) << "Private key is invalid."; 39 DVLOG(1) << "Private key is invalid.";
37 return nullptr; 40 return nullptr;
38 } 41 }
39 42
40 uint8_t public_key[kUncompressedP256PointBytes]; 43 uint8_t public_key[kUncompressedP256PointBytes];
41 if (EC_POINT_point2oct(EC_KEY_get0_group(private_key.get()), 44 if (EC_POINT_point2oct(EC_KEY_get0_group(private_key.get()),
42 EC_KEY_get0_public_key(private_key.get()), 45 EC_KEY_get0_public_key(private_key.get()),
43 POINT_CONVERSION_UNCOMPRESSED, public_key, 46 POINT_CONVERSION_UNCOMPRESSED, public_key,
44 sizeof(public_key), nullptr) != sizeof(public_key)) { 47 sizeof(public_key), nullptr) != sizeof(public_key)) {
45 DVLOG(1) << "Can't get public key."; 48 DVLOG(1) << "Can't get public key.";
46 return nullptr; 49 return nullptr;
47 } 50 }
48 51
49 return new P256KeyExchange(private_key.release(), public_key); 52 return new P256KeyExchange(std::move(private_key), public_key);
50 } 53 }
51 54
52 // static 55 // static
53 string P256KeyExchange::NewPrivateKey() { 56 string P256KeyExchange::NewPrivateKey() {
54 crypto::ScopedEC_KEY key(EC_KEY_new_by_curve_name(NID_X9_62_prime256v1)); 57 bssl::UniquePtr<EC_KEY> key(EC_KEY_new_by_curve_name(NID_X9_62_prime256v1));
55 if (!key.get() || !EC_KEY_generate_key(key.get())) { 58 if (!key.get() || !EC_KEY_generate_key(key.get())) {
56 DVLOG(1) << "Can't generate a new private key."; 59 DVLOG(1) << "Can't generate a new private key.";
57 return string(); 60 return string();
58 } 61 }
59 62
60 int key_len = i2d_ECPrivateKey(key.get(), nullptr); 63 int key_len = i2d_ECPrivateKey(key.get(), nullptr);
61 if (key_len <= 0) { 64 if (key_len <= 0) {
62 DVLOG(1) << "Can't convert private key to string"; 65 DVLOG(1) << "Can't convert private key to string";
63 return string(); 66 return string();
64 } 67 }
(...skipping 12 matching lines...) Expand all
77 return P256KeyExchange::New(private_value); 80 return P256KeyExchange::New(private_value);
78 } 81 }
79 82
80 bool P256KeyExchange::CalculateSharedKey(StringPiece peer_public_value, 83 bool P256KeyExchange::CalculateSharedKey(StringPiece peer_public_value,
81 string* out_result) const { 84 string* out_result) const {
82 if (peer_public_value.size() != kUncompressedP256PointBytes) { 85 if (peer_public_value.size() != kUncompressedP256PointBytes) {
83 DVLOG(1) << "Peer public value is invalid"; 86 DVLOG(1) << "Peer public value is invalid";
84 return false; 87 return false;
85 } 88 }
86 89
87 crypto::ScopedEC_POINT point( 90 bssl::UniquePtr<EC_POINT> point(
88 EC_POINT_new(EC_KEY_get0_group(private_key_.get()))); 91 EC_POINT_new(EC_KEY_get0_group(private_key_.get())));
89 if (!point || 92 if (!point ||
90 !EC_POINT_oct2point(/* also test if point is on curve */ 93 !EC_POINT_oct2point(/* also test if point is on curve */
91 EC_KEY_get0_group(private_key_.get()), point.get(), 94 EC_KEY_get0_group(private_key_.get()), point.get(),
92 reinterpret_cast<const uint8_t*>( 95 reinterpret_cast<const uint8_t*>(
93 peer_public_value.data()), 96 peer_public_value.data()),
94 peer_public_value.size(), nullptr)) { 97 peer_public_value.size(), nullptr)) {
95 DVLOG(1) << "Can't convert peer public value to curve point."; 98 DVLOG(1) << "Can't convert peer public value to curve point.";
96 return false; 99 return false;
97 } 100 }
(...skipping 12 matching lines...) Expand all
110 StringPiece P256KeyExchange::public_value() const { 113 StringPiece P256KeyExchange::public_value() const {
111 return StringPiece(reinterpret_cast<const char*>(public_key_), 114 return StringPiece(reinterpret_cast<const char*>(public_key_),
112 sizeof(public_key_)); 115 sizeof(public_key_));
113 } 116 }
114 117
115 QuicTag P256KeyExchange::tag() const { 118 QuicTag P256KeyExchange::tag() const {
116 return kP256; 119 return kP256;
117 } 120 }
118 121
119 } // namespace net 122 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/crypto/p256_key_exchange.h ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698