Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: net/quic/core/crypto/p256_key_exchange.h

Issue 2400033005: Use BoringSSL scopers in //net. (Closed)
Patch Set: avoid some unnecessary refcount-bumping Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 5 #ifndef NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
6 #define NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 6 #define NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
7 7
8 #include <openssl/base.h>
8 #include <stdint.h> 9 #include <stdint.h>
9 10
10 #include <memory> 11 #include <memory>
11 #include <string> 12 #include <string>
12 13
13 #include "base/macros.h" 14 #include "base/macros.h"
14 #include "base/strings/string_piece.h" 15 #include "base/strings/string_piece.h"
15 #include "crypto/openssl_util.h" 16 #include "crypto/openssl_util.h"
16 #include "crypto/scoped_openssl_types.h"
17 #include "net/base/net_export.h" 17 #include "net/base/net_export.h"
18 #include "net/quic/core/crypto/key_exchange.h" 18 #include "net/quic/core/crypto/key_exchange.h"
19 19
20 20
21 namespace net { 21 namespace net {
22 22
23 // P256KeyExchange implements a KeyExchange using elliptic-curve 23 // P256KeyExchange implements a KeyExchange using elliptic-curve
24 // Diffie-Hellman on NIST P-256. 24 // Diffie-Hellman on NIST P-256.
25 class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange { 25 class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange {
26 public: 26 public:
(...skipping 22 matching lines...) Expand all
49 // A P-256 point in uncompressed form consists of 0x04 (to denote 49 // A P-256 point in uncompressed form consists of 0x04 (to denote
50 // that the point is uncompressed) followed by two, 32-byte field 50 // that the point is uncompressed) followed by two, 32-byte field
51 // elements. 51 // elements.
52 kUncompressedP256PointBytes = 1 + 2 * kP256FieldBytes, 52 kUncompressedP256PointBytes = 1 + 2 * kP256FieldBytes,
53 // The first byte in an uncompressed P-256 point. 53 // The first byte in an uncompressed P-256 point.
54 kUncompressedECPointForm = 0x04, 54 kUncompressedECPointForm = 0x04,
55 }; 55 };
56 56
57 // P256KeyExchange takes ownership of |private_key|, and expects 57 // P256KeyExchange takes ownership of |private_key|, and expects
58 // |public_key| consists of |kUncompressedP256PointBytes| bytes. 58 // |public_key| consists of |kUncompressedP256PointBytes| bytes.
59 P256KeyExchange(EC_KEY* private_key, const uint8_t* public_key); 59 P256KeyExchange(EC_KEY* private_key, const uint8_t* public_key);
eroman 2016/10/10 22:45:55 side-comment: based on this description sounds lik
davidben 2016/10/10 23:24:40 You're right. Fixed.
60 60
61 crypto::ScopedEC_KEY private_key_; 61 bssl::UniquePtr<EC_KEY> private_key_;
62 // The public key stored as an uncompressed P-256 point. 62 // The public key stored as an uncompressed P-256 point.
63 uint8_t public_key_[kUncompressedP256PointBytes]; 63 uint8_t public_key_[kUncompressedP256PointBytes];
64 64
65 DISALLOW_COPY_AND_ASSIGN(P256KeyExchange); 65 DISALLOW_COPY_AND_ASSIGN(P256KeyExchange);
66 }; 66 };
67 67
68 } // namespace net 68 } // namespace net
69 #endif // NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_ 69 #endif // NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698