Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: net/ssl/ssl_client_session_cache.h

Issue 2400033005: Use BoringSSL scopers in //net. (Closed)
Patch Set: eroman comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/scoped_openssl_types.h ('k') | net/ssl/ssl_client_session_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_client_session_cache.h
diff --git a/net/ssl/ssl_client_session_cache.h b/net/ssl/ssl_client_session_cache.h
index 279561b89f24ea06f12b49675ca9d30b01c0e2d0..2f93aa3571c7812273413f5d043d56a788242a4b 100644
--- a/net/ssl/ssl_client_session_cache.h
+++ b/net/ssl/ssl_client_session_cache.h
@@ -5,7 +5,7 @@
#ifndef NET_SSL_SSL_CLIENT_SESSION_CACHE_H
#define NET_SSL_SSL_CLIENT_SESSION_CACHE_H
-#include <openssl/ssl.h>
+#include <openssl/base.h>
#include <stddef.h>
#include <memory>
@@ -20,7 +20,6 @@
#include "base/threading/thread_checker.h"
#include "base/time/time.h"
#include "net/base/net_export.h"
-#include "net/ssl/scoped_openssl_types.h"
namespace base {
class Clock;
@@ -46,7 +45,7 @@ class NET_EXPORT SSLClientSessionCache : public base::MemoryCoordinatorClient {
// Returns the session associated with |cache_key| and moves it to the front
// of the MRU list. Returns nullptr if there is none.
- ScopedSSL_SESSION Lookup(const std::string& cache_key);
+ bssl::UniquePtr<SSL_SESSION> Lookup(const std::string& cache_key);
// Inserts |session| into the cache at |cache_key|. If there is an existing
// one, it is released. Every |expiration_check_count| calls, the cache is
@@ -63,7 +62,7 @@ class NET_EXPORT SSLClientSessionCache : public base::MemoryCoordinatorClient {
CacheEntry();
~CacheEntry();
- ScopedSSL_SESSION session;
+ bssl::UniquePtr<SSL_SESSION> session;
// The time at which this entry was created.
base::Time creation_time;
};
« no previous file with comments | « net/ssl/scoped_openssl_types.h ('k') | net/ssl/ssl_client_session_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698