Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2399713003: cc: Replace viewport/clip rect with a viewport size for DirectRenderer (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 2 months ago
Reviewers:
enne (OOO)
CC:
boliu, cc-bugs_chromium.org, chromium-reviews, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Replace viewport/clip rect with a viewport size for DirectRenderer The viewport rect is always at 0,0 and the clip rect is always the viewport rect now that WebView does external viewport/clip things via embedding a SurfaceDrawQuad into another surface. So express this in the code. R=enne@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/ff1c583ed4f2d70249f3700515e26471d59fa9cf Cr-Commit-Position: refs/heads/master@{#423657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -262 lines) Patch
M cc/output/direct_renderer.h View 3 chunks +2 lines, -6 lines 0 comments Download
M cc/output/direct_renderer.cc View 6 chunks +9 lines, -33 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 44 chunks +127 lines, -158 lines 0 comments Download
M cc/output/overlay_unittest.cc View 11 chunks +12 lines, -13 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 14 chunks +32 lines, -41 lines 0 comments Download
M cc/surfaces/display.cc View 2 chunks +1 line, -5 lines 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
danakj
4 years, 2 months ago (2016-10-06 01:05:47 UTC) #3
danakj
4 years, 2 months ago (2016-10-06 01:06:39 UTC) #6
enne (OOO)
lgtm
4 years, 2 months ago (2016-10-06 18:01:24 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2392183003 Patch 40001). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-06 18:02:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399713003/1
4 years, 2 months ago (2016-10-06 20:24:01 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:36:46 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:39:41 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff1c583ed4f2d70249f3700515e26471d59fa9cf
Cr-Commit-Position: refs/heads/master@{#423657}

Powered by Google App Engine
This is Rietveld 408576698