Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3435)

Unified Diff: cc/output/direct_renderer.h

Issue 2399713003: cc: Replace viewport/clip rect with a viewport size for DirectRenderer (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/direct_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/direct_renderer.h
diff --git a/cc/output/direct_renderer.h b/cc/output/direct_renderer.h
index 3c4717a1208bc172f79aedb18182e514b68c7b8f..059fe48abbcdc0586483504024ced8092f3ffa64 100644
--- a/cc/output/direct_renderer.h
+++ b/cc/output/direct_renderer.h
@@ -55,8 +55,7 @@ class CC_EXPORT DirectRenderer {
void DrawFrame(RenderPassList* render_passes_in_draw_order,
float device_scale_factor,
const gfx::ColorSpace& device_color_space,
- const gfx::Rect& device_viewport_rect,
- const gfx::Rect& device_clip_rect);
+ const gfx::Size& device_viewport_size);
// Public interface implemented by subclasses.
virtual void SwapBuffers(CompositorFrameMetadata metadata) = 0;
@@ -81,8 +80,7 @@ class CC_EXPORT DirectRenderer {
const ScopedResource* current_texture = nullptr;
gfx::Rect root_damage_rect;
- gfx::Rect device_viewport_rect;
- gfx::Rect device_clip_rect;
+ gfx::Size device_viewport_size;
gfx::Transform projection_matrix;
gfx::Transform window_matrix;
@@ -111,8 +109,6 @@ class CC_EXPORT DirectRenderer {
gfx::Rect MoveFromDrawToWindowSpace(const DrawingFrame* frame,
const gfx::Rect& draw_rect) const;
- bool NeedDeviceClip(const DrawingFrame* frame) const;
- gfx::Rect DeviceClipRectInDrawSpace(const DrawingFrame* frame) const;
gfx::Rect DeviceViewportRectInDrawSpace(const DrawingFrame* frame) const;
gfx::Rect OutputSurfaceRectInDrawSpace(const DrawingFrame* frame) const;
static gfx::Rect ComputeScissorRectForRenderPass(const DrawingFrame* frame);
« no previous file with comments | « no previous file | cc/output/direct_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698