cc: Remove SurfaceSize from OutputSurface.

cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/a7e03fe1f42b541fa54b218808c1354fbf498e7e
Cr-Commit-Position: refs/heads/master@{#423650}

[danakj, 2016-10-06 00:06:06]

Description was changed from

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there execpt
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

R=enne@chromium.org
BUG=606056
==========

to

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there execpt
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-06 00:27:16]

Description was changed from

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there execpt
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there execpt
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-06 00:27:43]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:28:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-06 00:28:43]

Description was changed from

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there execpt
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-10-06 00:33:17]

lgtm

This cleanup is super good!

https://codereview.chromium.org/2392183003/diff/20001/cc/test/layer_tree_pixe...
File cc/test/layer_tree_pixel_test.cc (left):

https://codereview.chromium.org/2392183003/diff/20001/cc/test/layer_tree_pixe...
cc/test/layer_tree_pixel_test.cc:70: // Always test Webview shenanigans.
Yay deleting this

[commit-bot: I haz the power, 2016-10-06 00:50:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:50:35]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[danakj, 2016-10-06 01:01:58]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-10-06 01:03:10]

danakj@chromium.org changed reviewers:
+ rjkroege@chromium.org

[danakj, 2016-10-06 01:03:11]

+rjkroege for services/

[commit-bot: I haz the power, 2016-10-06 01:03:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 03:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 03:30:13]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-10-06 19:53:28]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-10-06 19:53:29]

lgtm

[danakj, 2016-10-06 20:13:31]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-10-06 20:13:32]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2392183003/#ps40001
(title: "nosurfacesize: ozonethinger")

[commit-bot: I haz the power, 2016-10-06 20:14:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:22:27]

Description was changed from

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-06 20:22:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 20:25:42]

Description was changed from

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove SurfaceSize from OutputSurface.

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/a7e03fe1f42b541fa54b218808c1354fbf498e7e
Cr-Commit-Position: refs/heads/master@{#423650}
==========

[commit-bot: I haz the power, 2016-10-06 20:25:43]

Patchset 3 (id:??) landed as
https://crrev.com/a7e03fe1f42b541fa54b218808c1354fbf498e7e
Cr-Commit-Position: refs/heads/master@{#423650}