Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3107)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2399713003: cc: Replace viewport/clip rect with a viewport size for DirectRenderer (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/software_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index d24bdebb08172a7b823f0f9a6ac6970e6b629c33..e14944ee68b67878c7e34a901bc1bcc46f0cfae9 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -1330,9 +1330,8 @@ class GLRendererWithOverlaysTest : public testing::Test {
renderer_->SetVisible(true);
}
- void DrawFrame(RenderPassList* pass_list, const gfx::Rect& viewport_rect) {
- renderer_->DrawFrame(pass_list, 1.f, gfx::ColorSpace(), viewport_rect,
- viewport_rect);
+ void DrawFrame(RenderPassList* pass_list, const gfx::Size& viewport_size) {
+ renderer_->DrawFrame(pass_list, 1.f, gfx::ColorSpace(), viewport_size);
}
void SwapBuffers() {
renderer_->SwapBuffers(CompositorFrameMetadata());
@@ -1369,7 +1368,7 @@ TEST_F(GLRendererWithOverlaysTest, OverlayQuadNotDrawn) {
bool use_validator = true;
Init(use_validator);
renderer_->set_expect_overlays(true);
- gfx::Rect viewport_rect(16, 16);
+ gfx::Size viewport_size(16, 16);
std::unique_ptr<RenderPass> pass = CreateRenderPass();
@@ -1395,7 +1394,7 @@ TEST_F(GLRendererWithOverlaysTest, OverlayQuadNotDrawn) {
kOverlayBottomRightRect,
BoundingRect(kUVTopLeft, kUVBottomRight)))
.Times(1);
- DrawFrame(&pass_list, viewport_rect);
+ DrawFrame(&pass_list, viewport_size);
EXPECT_EQ(1U, output_surface_->bind_framebuffer_count());
SwapBuffers();
@@ -1408,7 +1407,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadInUnderlay) {
bool use_validator = true;
Init(use_validator);
renderer_->set_expect_overlays(true);
- gfx::Rect viewport_rect(16, 16);
+ gfx::Size viewport_size(16, 16);
std::unique_ptr<RenderPass> pass = CreateRenderPass();
@@ -1435,7 +1434,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadInUnderlay) {
Schedule(-1, gfx::OVERLAY_TRANSFORM_NONE, _, kOverlayRect,
BoundingRect(kUVTopLeft, kUVBottomRight)))
.Times(1);
- DrawFrame(&pass_list, viewport_rect);
+ DrawFrame(&pass_list, viewport_size);
EXPECT_EQ(1U, output_surface_->bind_framebuffer_count());
SwapBuffers();
@@ -1448,7 +1447,7 @@ TEST_F(GLRendererWithOverlaysTest, NoValidatorNoOverlay) {
bool use_validator = false;
Init(use_validator);
renderer_->set_expect_overlays(false);
- gfx::Rect viewport_rect(16, 16);
+ gfx::Size viewport_size(16, 16);
std::unique_ptr<RenderPass> pass = CreateRenderPass();
@@ -1468,7 +1467,7 @@ TEST_F(GLRendererWithOverlaysTest, NoValidatorNoOverlay) {
output_surface_->set_is_displayed_as_overlay_plane(false);
EXPECT_CALL(*renderer_, DoDrawQuad(_, _, _)).Times(3);
EXPECT_CALL(scheduler_, Schedule(_, _, _, _, _)).Times(0);
- DrawFrame(&pass_list, viewport_rect);
+ DrawFrame(&pass_list, viewport_size);
EXPECT_EQ(1U, output_surface_->bind_framebuffer_count());
SwapBuffers();
Mock::VerifyAndClearExpectations(renderer_.get());
@@ -1482,7 +1481,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadNotDrawnWhenPartialSwapEnabled) {
bool use_validator = true;
Init(use_validator);
renderer_->set_expect_overlays(true);
- gfx::Rect viewport_rect(16, 16);
+ gfx::Size viewport_size(16, 16);
std::unique_ptr<RenderPass> pass = CreateRenderPass();
@@ -1500,7 +1499,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadNotDrawnWhenPartialSwapEnabled) {
output_surface_->set_is_displayed_as_overlay_plane(true);
EXPECT_CALL(*renderer_, DoDrawQuad(_, _, _)).Times(0);
EXPECT_CALL(scheduler_, Schedule(_, _, _, _, _)).Times(2);
- DrawFrame(&pass_list, viewport_rect);
+ DrawFrame(&pass_list, viewport_size);
EXPECT_EQ(1U, output_surface_->bind_framebuffer_count());
SwapBuffers();
Mock::VerifyAndClearExpectations(renderer_.get());
@@ -1513,7 +1512,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadNotDrawnWhenEmptySwapAllowed) {
bool use_validator = true;
Init(use_validator);
renderer_->set_expect_overlays(true);
- gfx::Rect viewport_rect(16, 16);
+ gfx::Size viewport_size(16, 16);
std::unique_ptr<RenderPass> pass = CreateRenderPass();
@@ -1532,7 +1531,7 @@ TEST_F(GLRendererWithOverlaysTest, OccludedQuadNotDrawnWhenEmptySwapAllowed) {
output_surface_->set_is_displayed_as_overlay_plane(true);
EXPECT_CALL(*renderer_, DoDrawQuad(_, _, _)).Times(0);
EXPECT_CALL(scheduler_, Schedule(_, _, _, _, _)).Times(2);
- DrawFrame(&pass_list, viewport_rect);
+ DrawFrame(&pass_list, viewport_size);
EXPECT_EQ(1U, output_surface_->bind_framebuffer_count());
SwapBuffers();
Mock::VerifyAndClearExpectations(renderer_.get());
« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/software_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698