chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java - Issue 2399183002: Do not allow sign in if Google play service is absent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Issue 2399183002: Do not allow sign in if Google play service is absent (Closed)

Patch Set: fix presubmit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

index 11a6d9752722375c3af115e18183096dd1e8f3e9..8f511df9e2a65033a4cb6f52f1392b825494bcbb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

@@ -380,7 +380,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta

* @return Whether sync promo should be displayed.

public boolean shouldDisplaySyncPromo() {

- if (SigninManager.get(mContext).isSigninDisabledByPolicy()) {

+ if (!SigninManager.get(mContext).isSignInAllowed()) {

return false;

}