Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

Issue 2399183002: Do not allow sign in if Google play service is absent (Closed)
Patch Set: fix presubmit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
index 77bbbb5efb193c59b3cedd0060ae845102f79d29..ed56cbf53a7dc3ddcd94c8122ce200cb6076b0d9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
@@ -237,7 +237,9 @@ public class SigninManager implements AccountTrackerService.OnSystemAccountsSeed
public boolean isSignInAllowed() {
return mSigninAllowedByPolicy && !mFirstRunCheckIsPending && mSignInState == null
&& ChromeSigninController.get(mContext).getSignedInUser() == null
- && !ApiCompatibilityUtils.isDemoUser(mContext);
+ && !ApiCompatibilityUtils.isDemoUser(mContext)
+ && ExternalAuthUtils.getInstance().canUseGooglePlayServices(mContext,
+ new UserRecoverableErrorHandler.Silent());
gogerald1 2016/10/07 14:19:28 It might be late to respond, but this will skip si
}
/**

Powered by Google App Engine
This is Rietveld 408576698