chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java - Issue 2399183002: Do not allow sign in if Google play service is absent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

Issue 2399183002: Do not allow sign in if Google play service is absent (Closed)

Patch Set: fix presubmit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

index 9089173dab2751ea4ea8dc9ca03d184de1af727e..77d493d0bb706200746d0273a5472cae0a7c475f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

@@ -89,7 +89,7 @@ public abstract class FirstRunFlowSequencer {

@VisibleForTesting

protected boolean isSyncAllowed() {

return FeatureUtilities.canAllowSync(mActivity)

- && !SigninManager.get(mActivity.getApplicationContext()).isSigninDisabledByPolicy();

+ && SigninManager.get(mActivity.getApplicationContext()).isSignInAllowed();

}

@VisibleForTesting