chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java - Issue 2399183002: Do not allow sign in if Google play service is absent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

Issue 2399183002: Do not allow sign in if Google play service is absent (Closed)

Patch Set: fix presubmit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

index 69a5f58ea060b00ac162c91e553e96da78d1a234..8028f288747bc9effc8dc04ec1fe8fbf53224378 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

@@ -47,7 +47,8 @@ public class SigninPromoItem extends StatusItem implements ItemGroup {

org.chromium.chrome.R.string.sign_in_button);

mDismissed = ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())

.getNewTabPageSigninPromoDismissed();

- mVisible = !SigninManager.get(ContextUtils.getApplicationContext()).isSignedInOnNative();

+ SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());

+ mVisible = signinManager.isSignInAllowed() && !signinManager.isSignedInOnNative();

}

@Override