content/browser/frame_host/navigation_request.cc - Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)

Patch Set: Always check vary Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index ba3a117e4417e3e3a67248fc1d29f30a8d6210f5..b901048ab1b987ce06ef6b7067dd584cff93a562 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -56,10 +56,11 @@ void UpdateLoadFlagsWithCacheFlags(

*load_flags |= net::LOAD_BYPASS_CACHE;

break;

case FrameMsg_Navigate_Type::RESTORE:

- *load_flags |= net::LOAD_PREFERRING_CACHE;

+ *load_flags |= net::LOAD_SKIP_CACHE_VALIDATION;

break;

case FrameMsg_Navigate_Type::RESTORE_WITH_POST:

- *load_flags |= net::LOAD_ONLY_FROM_CACHE;

+ *load_flags |=

+ net::LOAD_ONLY_FROM_CACHE | net::LOAD_SKIP_CACHE_VALIDATION;

break;

case FrameMsg_Navigate_Type::NORMAL:

if (is_post)