content/browser/loader/async_revalidation_manager.cc - Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/async_revalidation_manager.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)

Patch Set: Always check vary Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/async_revalidation_manager.cc

diff --git a/content/browser/loader/async_revalidation_manager.cc b/content/browser/loader/async_revalidation_manager.cc

index 53279fe132078ae6d2bb1241ac4f038217c9e91e..1a71ec7be799c33e10a1d6992e48400550fafb01 100644

--- a/content/browser/loader/async_revalidation_manager.cc

+++ b/content/browser/loader/async_revalidation_manager.cc

@@ -169,7 +169,7 @@ bool AsyncRevalidationManager::QualifiesForAsyncRevalidation(

const ResourceRequest& request) {

if (request.load_flags &

(net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE |

- net::LOAD_VALIDATE_CACHE | net::LOAD_PREFERRING_CACHE |

+ net::LOAD_VALIDATE_CACHE | net::LOAD_SKIP_CACHE_VALIDATION |

net::LOAD_ONLY_FROM_CACHE | net::LOAD_IGNORE_LIMITS |

net::LOAD_PREFETCH)) {

return false;