content/browser/download/save_file_manager.cc - Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file_manager.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)

Patch Set: Always check vary Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/save_file_manager.cc

diff --git a/content/browser/download/save_file_manager.cc b/content/browser/download/save_file_manager.cc

index 1603085fc23654120d63f523ad66f4993be16334..50f40f52a86da470222f1a19d23cb5c323e181a2 100644

--- a/content/browser/download/save_file_manager.cc

+++ b/content/browser/download/save_file_manager.cc

@@ -320,7 +320,7 @@ void SaveFileManager::OnSaveURL(const GURL& url,

// So far, for saving page, we need fetch content from cache, in the

// future, maybe we can use a configuration to configure this behavior.

- request->SetLoadFlags(net::LOAD_PREFERRING_CACHE);

+ request->SetLoadFlags(net::LOAD_SKIP_CACHE_VALIDATION);

// Check if the renderer is permitted to request the requested URL.

using AuthorizationState = SaveFileResourceHandler::AuthorizationState;