Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: content/browser/frame_host/navigation_request.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)
Patch Set: Always check vary Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigation_request.h" 5 #include "content/browser/frame_host/navigation_request.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "content/browser/devtools/render_frame_devtools_agent_host.h" 9 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
10 #include "content/browser/frame_host/frame_tree.h" 10 #include "content/browser/frame_host/frame_tree.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 switch (navigation_type) { 49 switch (navigation_type) {
50 case FrameMsg_Navigate_Type::RELOAD: 50 case FrameMsg_Navigate_Type::RELOAD:
51 case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE: 51 case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE:
52 case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL: 52 case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL:
53 *load_flags |= net::LOAD_VALIDATE_CACHE; 53 *load_flags |= net::LOAD_VALIDATE_CACHE;
54 break; 54 break;
55 case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE: 55 case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE:
56 *load_flags |= net::LOAD_BYPASS_CACHE; 56 *load_flags |= net::LOAD_BYPASS_CACHE;
57 break; 57 break;
58 case FrameMsg_Navigate_Type::RESTORE: 58 case FrameMsg_Navigate_Type::RESTORE:
59 *load_flags |= net::LOAD_PREFERRING_CACHE; 59 *load_flags |= net::LOAD_SKIP_CACHE_VALIDATION;
60 break; 60 break;
61 case FrameMsg_Navigate_Type::RESTORE_WITH_POST: 61 case FrameMsg_Navigate_Type::RESTORE_WITH_POST:
62 *load_flags |= net::LOAD_ONLY_FROM_CACHE; 62 *load_flags |=
63 net::LOAD_ONLY_FROM_CACHE | net::LOAD_SKIP_CACHE_VALIDATION;
63 break; 64 break;
64 case FrameMsg_Navigate_Type::NORMAL: 65 case FrameMsg_Navigate_Type::NORMAL:
65 if (is_post) 66 if (is_post)
66 *load_flags |= net::LOAD_VALIDATE_CACHE; 67 *load_flags |= net::LOAD_VALIDATE_CACHE;
67 break; 68 break;
68 default: 69 default:
69 break; 70 break;
70 } 71 }
71 } 72 }
72 73
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 DCHECK_EQ(request_params_.has_user_gesture, begin_params_.has_user_gesture); 560 DCHECK_EQ(request_params_.has_user_gesture, begin_params_.has_user_gesture);
560 561
561 render_frame_host->CommitNavigation(response_.get(), std::move(body_), 562 render_frame_host->CommitNavigation(response_.get(), std::move(body_),
562 common_params_, request_params_, 563 common_params_, request_params_,
563 is_view_source_); 564 is_view_source_);
564 565
565 frame_tree_node_->ResetNavigationRequest(true); 566 frame_tree_node_->ResetNavigationRequest(true);
566 } 567 }
567 568
568 } // namespace content 569 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/save_file_manager.cc ('k') | content/browser/loader/async_revalidation_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698