Move Layout Tree Construction code into Element::rebuildLayoutTree()

Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp.

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
Committed: https://crrev.com/651c13992922ce5c2b0dd0072c5c3e4a59a03b87
Cr-Original-Commit-Position: refs/heads/master@{#426353}
Cr-Commit-Position: refs/heads/master@{#427612}

[nainar, 2016-10-07 02:11:01]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 02:11:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-07 02:13:30]

Description was changed from

==========
Run git cl format third_party/WebKit


Make rebuildLayoutTree() public to be accessed in Document.cpp


Add ability to reattach the Layout Tree of PseudoElements by calling
reattachPseudoElementLayoutTree() in rebuildLayoutTree(). Also added some
comments explaining some design decisions.


Move reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and use
dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree on children nodes. Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html


Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

This patch sets the NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree flags on Node correctly in
Element::recalcOwnStyle.
BUG=595137

patch from issue 2375293002 at patchset 80001
(http://crrev.com/2375293002#ps80001)
==========

to

==========
WIP CL

Run git cl format third_party/WebKit

Make rebuildLayoutTree() public to be accessed in Document.cpp

Add ability to reattach the Layout Tree of PseudoElements by calling
reattachPseudoElementLayoutTree() in rebuildLayoutTree(). Also added some
comments explaining some design decisions.

Move reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and use
dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree on children nodes. Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html

Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

This patch sets the NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree flags on Node correctly in
Element::recalcOwnStyle.

patch from issue 2375293002 at patchset 80001
(http://crrev.com/2375293002#ps80001)

BUG=595137
==========

[commit-bot: I haz the power, 2016-10-07 02:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:21:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2016-10-07 03:04:49]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 03:05:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-07 03:06:15]

Description was changed from

==========
WIP CL

Run git cl format third_party/WebKit

Make rebuildLayoutTree() public to be accessed in Document.cpp

Add ability to reattach the Layout Tree of PseudoElements by calling
reattachPseudoElementLayoutTree() in rebuildLayoutTree(). Also added some
comments explaining some design decisions.

Move reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and use
dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree on children nodes. Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html

Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

This patch sets the NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree flags on Node correctly in
Element::recalcOwnStyle.

patch from issue 2375293002 at patchset 80001
(http://crrev.com/2375293002#ps80001)

BUG=595137
==========

to

==========
WIP CL

Run git cl format third_party/WebKit

Add option 2: store the textSibling passed to recalcStyle() and use that
information in rebuildLayoutTree()

Make rebuildLayoutTree() public to be accessed in Document.cpp

Add ability to reattach the Layout Tree of PseudoElements by calling
reattachPseudoElementLayoutTree() in rebuildLayoutTree(). Also added some
comments explaining some design decisions.

Move reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and use
dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree on children nodes. Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html

Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

This patch sets the NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree flags on Node correctly in
Element::recalcOwnStyle.

patch from issue 2375293002 at patchset 80001
(http://crrev.com/2375293002#ps80001)

BUG=595137
==========

[nainar, 2016-10-07 03:14:33]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2016-10-07 03:36:15]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 03:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-07 03:53:38]

CL for src perf tryjob to run blink_style.top_25 benchmark on all platform(s)

[nainar, 2016-10-07 04:43:04]

Patchset #4 (id:60001) has been deleted

[nainar, 2016-10-07 05:04:10]

Description was changed from

==========
WIP CL

Run git cl format third_party/WebKit

Add option 2: store the textSibling passed to recalcStyle() and use that
information in rebuildLayoutTree()

Make rebuildLayoutTree() public to be accessed in Document.cpp

Add ability to reattach the Layout Tree of PseudoElements by calling
reattachPseudoElementLayoutTree() in rebuildLayoutTree(). Also added some
comments explaining some design decisions.

Move reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and use
dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree on children nodes. Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html

Set NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree flags on Node

This patch sets the NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree flags on Node correctly in
Element::recalcOwnStyle.

patch from issue 2375293002 at patchset 80001
(http://crrev.com/2375293002#ps80001)

BUG=595137
==========

to

==========
WIP CL: Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It adds the ability to reattach the Layout Tree of PseudoElements by creating 
and calling reattachPseudoElementLayoutTree() in rebuildLayoutTree(). 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. These are temporary 
and will be removed later.

Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html
Uploading this patch for a design review only

BUG=595137
==========

[nainar, 2016-10-07 05:04:11]

nainar@chromium.org changed reviewers:
+ esprehn@chromium.org

[nainar, 2016-10-07 05:05:05]

esprehn,

Uploading this patch for a design review, PTAL? Thanks! :)

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (left):

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:1898: 
Moved this to rebuildLayoutTree()

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:2010: // This is information
passed on to recalcStyle from recalcDescendantStyles
Need to decide if this method is preferable or whether we want to store the Text
node from recalcStyle and use that here in rebuildLayoutTree

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/2398293003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.h:403: StyleRecalcChange
rebuildLayoutTree();
Moved this here because it will need to be accessed in Document in a future CL

[nainar, 2016-10-09 23:11:10]

nainar@chromium.org changed reviewers:
+ bugsnash@chromium.org

[nainar, 2016-10-09 23:11:10]

Moving bugsnash from cc to a reviewer.

[nainar, 2016-10-09 23:16:50]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-09 23:16:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 00:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 00:37:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nainar, 2016-10-10 04:18:09]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 04:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-10 04:30:12]

Description was changed from

==========
WIP CL: Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It adds the ability to reattach the Layout Tree of PseudoElements by creating 
and calling reattachPseudoElementLayoutTree() in rebuildLayoutTree(). 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. These are temporary 
and will be removed later.

Note that the following test still fails:
fast/block/float/add-inline-to-block-flow-with-block-children-that-do-not-need-anonymous-boxes.html
Uploading this patch for a design review only

BUG=595137
==========

to

==========
WIP CL: Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It adds the ability to reattach the Layout Tree of PseudoElements by creating 
and calling reattachPseudoElementLayoutTree() in rebuildLayoutTree(). 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. These are temporary 
and will be removed later.

BUG=595137
==========

[commit-bot: I haz the power, 2016-10-10 05:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 05:42:19]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-10-10 21:50:43]

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2001: for (Node* child =
firstChild(); child && child->isElementNode();
this breaks at the first non element, ex. text or comment.

you need:

if (node->isElementNode())
  
inside the loop.

Also you don't handle Shadow DOM here, you need to iterate the ShadowRoots
first, see how ::recalcStyle does this:

      for (ShadowRoot* root = youngestShadowRoot(); root;
           root = root->olderShadowRoot()) {

Actually I think this entire side of the branch is unreachable because you only
call this inside recalcOwnStyle right now right after calling
setNeedsReattachLayoutTree() we always take the needsReattachLayoutTree().

Maybe we remove this side of the if statement and make it NOTREACHED() for this
patch. The next patch that move rebuildLayoutTree to be it's own step in
updateStyle() will fill it in.

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2015: for (Node* child =
parentNode()->lastChild(); child;
This is n^2, if you appendChild 500 elements, this always iterates from the end
to yourself.

I think we want to just start at |this| and iterate until we find the next
whitespace sibling.

[nainar, 2016-10-10 22:53:57]

Description was changed from

==========
WIP CL: Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It adds the ability to reattach the Layout Tree of PseudoElements by creating 
and calling reattachPseudoElementLayoutTree() in rebuildLayoutTree(). 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. These are temporary 
and will be removed later.

BUG=595137
==========

to

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

[nainar, 2016-10-10 22:54:19]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:54:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-10 22:56:34]

Elliott, 

PTAL? 

Thanks!

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2001: for (Node* child =
firstChild(); child && child->isElementNode();
Added NOTREACHED() here and noted the changes needed for a future patch.

https://codereview.chromium.org/2398293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2015: for (Node* child =
parentNode()->lastChild(); child;
Done. Starting iteration from this->nextSibling. 

Can change this to checking in the if condition that the node in consideration
is not this itself.

[commit-bot: I haz the power, 2016-10-11 00:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:25:00]

Dry run: This issue passed the CQ dry run.

[nainar, 2016-10-12 01:54:26]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 01:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 03:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 03:42:50]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2016-10-14 00:36:47]

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1998: else if
(childNeedsReattachLayoutTree())
I think this would be better as a DCHECK

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2004: // (like WebKit does).
I wouldn't include what webkit does in a comment - it might change

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2009: if
(sibling->isElementNode() && toElement(sibling)->layoutObject()) {
could avoid this branch by adding it to the for loop conditional

[nainar, 2016-10-14 03:05:19]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 03:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-14 03:28:10]

@bugsnash, 

Made the changes you asked for. PTAL? Thanks!

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1998: else if
(childNeedsReattachLayoutTree())
Done.

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2004: // (like WebKit does).
Done.

https://codereview.chromium.org/2398293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2009: if
(sibling->isElementNode() && toElement(sibling)->layoutObject()) {
Done.

[commit-bot: I haz the power, 2016-10-14 05:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 05:27:30]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2016-10-17 00:17:05]

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1996: if
(needsReattachLayoutTree())
what is the purpose of this check? it doesn't seem necessary at this point

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1999:
DCHECK(!childNeedsReattachLayoutTree());
add a comment explaining why we expect this DCHECK to be true (i.e.
reattachLayoutTree handles the children)

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2002: Text* nextTextSibling =
nullptr;
the comment about the trade off between storage and calculation was good, I just
meant to remove the part about webkit.

I think this would be better separated into its own method nextTextSibling(),
possibly on Node, which can return null if the next sibling is not an Element or
doesn't have a layout object. In future once Text mirrors Element this could
even be called from within reattachWhitespaceSiblings itself instead of being
passed here.

[nainar, 2016-10-17 16:28:46]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 16:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-17 16:29:12]

@bugsnash, 

Made the changes requested. PTAL? Thanks!

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1996: if
(needsReattachLayoutTree())
Moved to a DCHECK and added an explainer comment here as well.

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1999:
DCHECK(!childNeedsReattachLayoutTree());
Done.

https://codereview.chromium.org/2398293003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2002: Text* nextTextSibling =
nullptr;
Edited the comment. 

Moved code to function.

[commit-bot: I haz the power, 2016-10-17 17:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:57:48]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-10-17 21:28:55]

Description was changed from

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for 
them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and 
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

to

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call 
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

[esprehn, 2016-10-17 21:29:06]

Description was changed from

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call 
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

to

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call 
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

[esprehn, 2016-10-17 21:36:26]

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1893:
clearChildNeedsReattachLayoutTree();
Note that once you start walking the tree you're not going to want to clear the
clearChildNeedsReattachLayoutTree bit here. These bits should only be touched
inside reattachLayoutTree.

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1990: AttachContext
reattachContext;
DCHECK(inActiveDocument()) in this function

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2002:
DCHECK(!childNeedsReattachLayoutTree());
DCHECK(parentNode());
DCHECK(parentNode()->childNeedsReattachLayoutTree());

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.cpp:396: !(sibling->isElementNode() &&
toElement(sibling)->layoutObject());
Run demorgans :)

(!sibling->isElementNode() || !toElement(sibling)->layoutObject())

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:136:
clearChildNeedsReattachLayoutTree();
ditto, you won't want to touch the reattach bits in recalcStyle once you start
tree walking inside reattachLayoutTree.

[nainar, 2016-10-18 00:03:54]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2016-10-18 00:04:41]

@esprehn,

Made the changes you asked for, PTAL? Thanks!

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1893:
clearChildNeedsReattachLayoutTree();
Done.

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1990: AttachContext
reattachContext;
Done.

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:2002:
DCHECK(!childNeedsReattachLayoutTree());
Done.

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Node.cpp:396: !(sibling->isElementNode() &&
toElement(sibling)->layoutObject());
Done.

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/2398293003/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:136:
clearChildNeedsReattachLayoutTree();
Done.

[commit-bot: I haz the power, 2016-10-18 00:05:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:54:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-10-18 02:00:10]

This introduced an n^2 looking for the next text sibling which makes me a little
nervous but I say let's go for it and figure out it later. Speaking of there's
n^2 protection in the form of needsAttach() getter that's used during layout
tree construction. We need to figure out how to make that work in the next patch
by looking at the bits you added here.

https://codereview.chromium.org/2398293003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Element.cpp (left):

https://codereview.chromium.org/2398293003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Element.cpp:1898:
reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
We don't need the nextTextSibling here anymore so we could remove the argument
in a follow up patch?

[esprehn, 2016-10-18 02:00:17]

lgtm

[nainar, 2016-10-18 08:23:24]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 08:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2016-10-18 09:12:25]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2016-10-18 10:56:31]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 10:56:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 13:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 13:33:03]

Dry run: This issue passed the CQ dry run.

[nainar, 2016-10-19 22:04:24]

The CQ bit was checked by nainar@chromium.org

[nainar, 2016-10-19 22:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2398293003/#ps240001
(title: "Final patch to land")

[commit-bot: I haz the power, 2016-10-19 22:05:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:31:32]

Committed patchset #12 (id:240001)

[commit-bot: I haz the power, 2016-10-21 13:13:52]

Description was changed from

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp. 

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call 
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137
==========

to

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp.

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137

Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
Cr-Commit-Position: refs/heads/master@{#426353}
==========

[commit-bot: I haz the power, 2016-10-21 13:13:53]

Patchset 12 (id:??) landed as
https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
Cr-Commit-Position: refs/heads/master@{#426353}

[nainar, 2016-10-22 06:13:22]

Going to revert this patch as it is suspected to cause crbug.com/658322. 

Since I am OOO - I can't actually investigate till I get into Sydney. So going
to revert to be safe.

[nainar, 2016-10-22 06:14:16]

A revert of this CL (patchset #12 id:240001) has been created in
https://codereview.chromium.org/2439973005/ by nainar@chromium.org.

The reason for reverting is: Suspected to cause crbug.com/658322..

[nainar, 2016-10-26 04:31:14]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:31:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:47:25]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[nainar, 2016-10-26 04:59:37]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 05:00:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 06:09:00]

Dry run: This issue passed the CQ dry run.

[nainar, 2016-10-26 06:21:06]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2016-10-26 06:21:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:35:36]

Committed patchset #12 (id:240001)

[commit-bot: I haz the power, 2016-10-26 06:37:51]

Description was changed from

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp.

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137

Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
Cr-Commit-Position: refs/heads/master@{#426353}
==========

to

==========
Move Layout Tree Construction code into Element::rebuildLayoutTree()

This patch uses the two dirty bits (NeedsReattachLayoutTree and
ChildNeedsReattachLayoutTree) on Node and adds the relevant
getters/setters for them.

It makes rebuildLayoutTree() public to be accessed in Document.cpp.

It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
uses dirtyBits to call either reattachLayoutTree() on node itself or call
rebuildLayoutTree() on children nodes.

Also added some comments explaining some design decisions. Will be removed
upon completion of separation.

BUG=595137

Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
Committed: https://crrev.com/651c13992922ce5c2b0dd0072c5c3e4a59a03b87
Cr-Original-Commit-Position: refs/heads/master@{#426353}
Cr-Commit-Position: refs/heads/master@{#427612}
==========

[commit-bot: I haz the power, 2016-10-26 06:37:52]

Patchset 12 (id:??) landed as
https://crrev.com/651c13992922ce5c2b0dd0072c5c3e4a59a03b87
Cr-Commit-Position: refs/heads/master@{#427612}