Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2398293003: Move Layout Tree Construction code into Element::rebuildLayoutTree() (Closed)
Patch Set: Final patch to land Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 11f5f6195d2fef8f83d6e1439ef6cbdc663640f5..14fc4bb837fa35232739c6d17403adce4e3c4531 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1778,6 +1778,8 @@ static void assertLayoutTreeUpdated(Node& root) {
continue;
DCHECK(!node.needsStyleRecalc());
DCHECK(!node.childNeedsStyleRecalc());
+ DCHECK(!node.needsReattachLayoutTree());
+ DCHECK(!node.childNeedsReattachLayoutTree());
DCHECK(!node.childNeedsDistributionRecalc());
DCHECK(!node.needsStyleInvalidation());
DCHECK(!node.childNeedsStyleInvalidation());
@@ -1910,6 +1912,7 @@ void Document::updateStyle() {
}
clearNeedsStyleRecalc();
+ clearNeedsReattachLayoutTree();
StyleResolver& resolver = ensureStyleResolver();
@@ -1932,6 +1935,7 @@ void Document::updateStyle() {
// LayoutTreeConstruction.
m_nonAttachedStyle.clear();
clearChildNeedsStyleRecalc();
+ clearChildNeedsReattachLayoutTree();
resolver.clearStyleSharingList();
@@ -1939,6 +1943,8 @@ void Document::updateStyle() {
DCHECK(!needsStyleRecalc());
DCHECK(!childNeedsStyleRecalc());
+ DCHECK(!needsReattachLayoutTree());
+ DCHECK(!childNeedsReattachLayoutTree());
DCHECK(inStyleRecalc());
DCHECK_EQ(styleResolver(), &resolver);
DCHECK(m_nonAttachedStyle.isEmpty());
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698