Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2439973005: Revert of Move Layout Tree Construction code into Element::rebuildLayoutTree() (Closed)

Created:
4 years, 2 months ago by nainar
Modified:
4 years, 2 months ago
Reviewers:
esprehn, Bugs Nash
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Bugs Nash, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move Layout Tree Construction code into Element::rebuildLayoutTree() (patchset #12 id:240001 of https://codereview.chromium.org/2398293003/ ) Reason for revert: Suspected to cause crbug.com/658322. Original issue's description: > Move Layout Tree Construction code into Element::rebuildLayoutTree() > > This patch uses the two dirty bits (NeedsReattachLayoutTree and > ChildNeedsReattachLayoutTree) on Node and adds the relevant > getters/setters for them. > > It makes rebuildLayoutTree() public to be accessed in Document.cpp. > > It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and > uses dirtyBits to call either reattachLayoutTree() on node itself or call > rebuildLayoutTree() on children nodes. > > Also added some comments explaining some design decisions. Will be removed > upon completion of separation. > > BUG=595137 > > Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee > Cr-Commit-Position: refs/heads/master@{#426353} TBR=esprehn@chromium.org,bugsnash@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595137 Committed: https://crrev.com/352b045421e6e2ceeba083eeebd27f64adf41194 Cr-Commit-Position: refs/heads/master@{#426991}

Patch Set 1 #

Patch Set 2 : Revert "Move Layout Tree Construction code into Element::rebuildLayoutTree()" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -80 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 5 chunks +5 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 3 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
nainar
Created Revert of Move Layout Tree Construction code into Element::rebuildLayoutTree()
4 years, 2 months ago (2016-10-22 06:14:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439973005/1
4 years, 2 months ago (2016-10-22 06:14:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/320550)
4 years, 2 months ago (2016-10-22 06:16:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439973005/200001
4 years, 2 months ago (2016-10-22 12:58:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 2 months ago (2016-10-22 13:07:14 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 13:09:23 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/352b045421e6e2ceeba083eeebd27f64adf41194
Cr-Commit-Position: refs/heads/master@{#426991}

Powered by Google App Engine
This is Rietveld 408576698