Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2396953002: Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" (Closed)

Created:
4 years, 2 months ago by reed1
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" This reverts commit c245574ba3d0e2ade6c94b2812de3baa383bf4c4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2396953002 TBR= Committed: https://skia.googlesource.com/skia/+/374772bd61951f01bf84fe17bf53d8867681c9ae

Patch Set 1 #

Patch Set 2 : roll in printf fix #

Patch Set 3 : add tmp virtual to unroll legacy arithmodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1210 lines, -1117 lines) Patch
M bench/RectBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/RotatedRectBench.cpp View 3 chunks +41 lines, -41 lines 0 comments Download
M bench/XfermodeBench.cpp View 3 chunks +37 lines, -62 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fuzz/FilterFuzz.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M gm/aaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/aarectmodes.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M gm/aaxfermodes.cpp View 6 chunks +11 lines, -12 lines 0 comments Download
M gm/bitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blurredclippedcircle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colortypexfermode.cpp View 2 chunks +33 lines, -33 lines 0 comments Download
M gm/drawatlas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/drawatlascolor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dstreadshuffle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/gamma.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M gm/gm.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/hairmodes.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M gm/imagefilters.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/lcdblendmodes.cpp View 2 chunks +33 lines, -33 lines 0 comments Download
M gm/lcdoverlap.cpp View 4 chunks +8 lines, -12 lines 0 comments Download
M gm/lumafilter.cpp View 3 chunks +10 lines, -9 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/picture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/plus.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/srcmode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/textblobblockreordering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textbloblooper.cpp View 3 chunks +20 lines, -20 lines 0 comments Download
M gm/texteffects.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodeimagefilter.cpp View 8 chunks +45 lines, -47 lines 0 comments Download
M gm/xfermodes.cpp View 3 chunks +36 lines, -37 lines 0 comments Download
M gm/xfermodes2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/xfermodes3.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/core/SkBlendMode.h View 1 chunk +51 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +14 lines, -4 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 5 chunks +11 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkXfermode.h View 1 2 6 chunks +35 lines, -1 line 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 3 chunks +14 lines, -3 lines 0 comments Download
M include/gpu/GrPaint.h View 2 chunks +5 lines, -1 line 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleAARectModes.cpp View 4 chunks +17 lines, -18 lines 0 comments Download
M samplecode/SampleAll.cpp View 10 chunks +14 lines, -14 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFatBits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleFuzz.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M samplecode/SampleHairModes.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M samplecode/SampleLayerMask.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleLayers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SamplePathClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleQuadStroker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M samplecode/SampleXfer.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 4 chunks +19 lines, -32 lines 0 comments Download
M src/c/sk_paint.cpp View 2 chunks +32 lines, -31 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
A src/core/SkBlendModePriv.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkBlitter_A8.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkBlitter_PM4f.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 5 chunks +6 lines, -8 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +7 lines, -12 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M src/core/SkGpuBlurUtils.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMatrixImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 23 chunks +51 lines, -39 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPixmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRasterPipelineBlitter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +17 lines, -24 lines 0 comments Download
M src/core/SkRecordOpts.cpp View 3 chunks +5 lines, -9 lines 0 comments Download
M src/core/SkSpriteBlitter4f.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M src/core/SkXfermodeInterpretation.cpp View 1 chunk +9 lines, -16 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticModePriv.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkImageSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTileImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 14 chunks +70 lines, -30 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureToYUVPlanes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 20 chunks +79 lines, -85 lines 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 5 chunks +50 lines, -55 lines 0 comments Download
M src/pipe/SkPipeCanvas.cpp View 3 chunks +1 line, -10 lines 0 comments Download
M src/pipe/SkPipeFormat.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/pipe/SkPipeReader.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/utils/SkLua.cpp View 6 chunks +0 lines, -40 lines 0 comments Download
M src/utils/SkRGBAToYUV.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/xps/SkXPSDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ApplyGammaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/LayerDrawLooperTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M tests/PDFOpaqueSrcModeToSrcOverTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/PaintTest.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordOptsTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/RecordingXfermodeTest.cpp View 6 chunks +9 lines, -11 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 4 chunks +0 lines, -23 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/mac/RasterWindowContext_mac.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396953002/40001
4 years, 2 months ago (2016-10-06 00:31:09 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 00:33:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/374772bd61951f01bf84fe17bf53d8867681c9ae

Powered by Google App Engine
This is Rietveld 408576698