src/utils/SkRGBAToYUV.cpp - Issue 2396953002: Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkRGBAToYUV.cpp

Issue 2396953002: Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" (Closed)

Patch Set: add tmp virtual to unroll legacy arithmodes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkRGBAToYUV.cpp

diff --git a/src/utils/SkRGBAToYUV.cpp b/src/utils/SkRGBAToYUV.cpp

index 63d91523620f05b1863526ac931e90d1a423693d..0528b144f0bd86b9ef03d81273d4120406f7ab08 100644

--- a/src/utils/SkRGBAToYUV.cpp

+++ b/src/utils/SkRGBAToYUV.cpp

@@ -45,7 +45,7 @@ bool SkRGBAToYUV(const SkImage* image, const SkISize sizes[3], void* const plane

}

SkPaint paint;

paint.setFilterQuality(kLow_SkFilterQuality);

- paint.setXfermodeMode(SkXfermode::kSrc_Mode);

+ paint.setBlendMode(SkBlendMode::kSrc);

int rowStartIdx = 5 * i;

const SkScalar* row = kYUVColorSpaceInvMatrices[colorSpace] + rowStartIdx;

paint.setColorFilter(

« no previous file with comments | « src/utils/SkLua.cpp ('k') | src/xps/SkXPSDevice.cpp » ('j') | no next file with comments »