src/effects/SkImageSource.cpp - Issue 2396953002: Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkImageSource.cpp

Issue 2396953002: Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints" (Closed)

Patch Set: add tmp virtual to unroll legacy arithmodes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkImageSource.cpp

diff --git a/src/effects/SkImageSource.cpp b/src/effects/SkImageSource.cpp

index f434de4aa0975ac655cf3990a2286ad8abb80cf9..f96a4a16769b04e27f6032fa4a0f362313ae8138 100644

--- a/src/effects/SkImageSource.cpp

+++ b/src/effects/SkImageSource.cpp

@@ -108,7 +108,7 @@ sk_sp<SkSpecialImage> SkImageSource::onFilterImage(SkSpecialImage* source, const

// Subtract off the integer component of the translation (will be applied in offset, below).

dstRect.offset(-SkIntToScalar(dstIRect.fLeft), -SkIntToScalar(dstIRect.fTop));

- paint.setXfermodeMode(SkXfermode::kSrc_Mode);

+ paint.setBlendMode(SkBlendMode::kSrc);

// FIXME: this probably shouldn't be necessary, but drawImageRect asserts

// None filtering when it's translate-only

paint.setFilterQuality(

« no previous file with comments | « src/effects/SkDropShadowImageFilter.cpp ('k') | src/effects/SkLayerDrawLooper.cpp » ('j') | no next file with comments »