Revert of Reland "Turn libbase into a component"

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
@@ skipping 112 matching lines @@
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 }
 
 # This config should be applied to code using the libplatform.
 config("libplatform_config") {
   include_dirs = [ "include" ]
 }
 
-# This config should be applied to code using the libbase.
-config("libbase_config") {
-  if (is_component_build) {
-    defines = [ "USING_V8_BASE_SHARED" ]
-  }
-  libs = []
-  if (is_android && current_toolchain != host_toolchain) {
-    libs += [ "log" ]
-  }
-}
-
 # This config should be applied to code using the libsampler.
 config("libsampler_config") {
   include_dirs = [ "include" ]
 }
 
 # This config should only be applied to code using V8 and not any V8 code
 # itself.
 config("external_config") {
   if (is_component_build) {
     defines = [ "USING_V8_SHARED" ]
   }
   include_dirs = [ "include" ]
   if (v8_enable_inspector_override) {
     include_dirs += [ "$target_gen_dir/include" ]
   }
+  libs = []
+  if (is_android && current_toolchain != host_toolchain) {
+    libs += [ "log" ]
+  }
 }
 
 # This config should only be applied to code that needs to be explicitly
 # aware of whether we are using startup data or not.
 config("external_startup_data") {
   if (v8_use_external_startup_data) {
     defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
   }
 }
 
@@ skipping 1981 matching lines @@
   if (v8_postmortem_support) {
     sources += [ "$target_gen_dir/debug-support.cc" ]
     deps += [ ":postmortem-metadata" ]
   }
 
   if (v8_enable_inspector_override) {
     deps += [ "src/inspector:inspector" ]
   }
 }
 
-v8_component("v8_libbase") {
+v8_source_set("v8_libbase") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+
   sources = [
     "src/base/adapters.h",
     "src/base/atomic-utils.h",
     "src/base/atomicops.h",
     "src/base/atomicops_internals_arm64_gcc.h",
     "src/base/atomicops_internals_arm_gcc.h",
     "src/base/atomicops_internals_atomicword_compat.h",
     "src/base/atomicops_internals_mac.h",
     "src/base/atomicops_internals_mips64_gcc.h",
     "src/base/atomicops_internals_mips_gcc.h",
     "src/base/atomicops_internals_s390_gcc.h",
     "src/base/atomicops_internals_tsan.h",
     "src/base/atomicops_internals_x86_gcc.cc",
     "src/base/atomicops_internals_x86_gcc.h",
     "src/base/atomicops_internals_x86_msvc.h",
-    "src/base/base-export.h",
     "src/base/bits.cc",
     "src/base/bits.h",
     "src/base/build_config.h",
     "src/base/compiler-specific.h",
     "src/base/cpu.cc",
     "src/base/cpu.h",
     "src/base/debug/stack_trace.cc",
     "src/base/debug/stack_trace.h",
     "src/base/division-by-constant.cc",
     "src/base/division-by-constant.h",
@@ skipping 30 matching lines @@
     "src/base/safe_math.h",
     "src/base/safe_math_impl.h",
     "src/base/sys-info.cc",
     "src/base/sys-info.h",
     "src/base/utils/random-number-generator.cc",
     "src/base/utils/random-number-generator.h",
   ]
 
   configs = [ ":internal_config_base" ]
 
-  public_configs = [ ":libbase_config" ]
-
   defines = []
 
-  if (is_component_build) {
-    defines = [ "BUILDING_V8_BASE_SHARED" ]
-  }
-
   if (is_posix) {
     sources += [ "src/base/platform/platform-posix.cc" ]
   }
 
   if (is_linux) {
     sources += [
       "src/base/debug/stack_trace_posix.cc",
       "src/base/platform/platform-linux.cc",
     ]
 
@@ skipping 123 matching lines @@
     "test/fuzzer/fuzzer-support.h",
   ]
 
   configs = [ ":internal_config_base" ]
 
   deps = [
     ":v8_maybe_snapshot",
   ]
 
   public_deps = [
-    ":v8_libbase",
     ":v8_libplatform",
   ]
 }
 
 v8_source_set("simple_fuzzer") {
   sources = [
     "test/fuzzer/fuzzer.cc",
   ]
 
   configs = [ ":internal_config_base" ]
 }
 
 ###############################################################################
 # Executables
 #
 
 if (current_toolchain == v8_snapshot_toolchain) {
   v8_executable("mksnapshot") {
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
     sources = [
       "src/snapshot/mksnapshot.cc",
     ]
 
     configs = [ ":internal_config" ]
 
     deps = [
       ":v8_base",
-      ":v8_libbase",
       ":v8_libplatform",
       ":v8_nosnapshot",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
   }
 }
 
 v8_executable("mkpeephole") {
   # mkpeephole needs to be built for the build host so the peephole lookup
@@ skipping 102 matching lines @@
   configs = [
     # Note: don't use :internal_config here because this target will get
     # the :external_config applied to it by virtue of depending on :v8, and
     # you can't have both applied to the same target.
     ":internal_config_base",
   ]
 
   deps = [
     ":d8_js2c",
     ":v8",
-    ":v8_libbase",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
   # TODO(jochen): Add support for vtunejit.
 
   if (is_posix) {
     sources += [ "src/d8-posix.cc" ]
   } else if (is_win) {
@@ skipping 20 matching lines @@
 
   configs = [
     # Note: don't use :internal_config here because this target will get
     # the :external_config applied to it by virtue of depending on :v8, and
     # you can't have both applied to the same target.
     ":internal_config_base",
   ]
 
   deps = [
     ":v8",
-    ":v8_libbase",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
   if (v8_enable_i18n_support) {
     deps += [ "//third_party/icu" ]
   }
 }
 
 v8_executable("v8_sample_process") {
   sources = [
     "samples/process.cc",
   ]
 
   configs = [
     # Note: don't use :internal_config here because this target will get
     # the :external_config applied to it by virtue of depending on :v8, and
     # you can't have both applied to the same target.
     ":internal_config_base",
   ]
 
   deps = [
     ":v8",
-    ":v8_libbase",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
   if (v8_enable_i18n_support) {
     deps += [ "//third_party/icu" ]
   }
 }
 
 v8_executable("v8_parser_shell") {
   sources = [
     "tools/parser-shell.cc",
     "tools/shell-utils.h",
   ]
 
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 
   deps = [
-    ":v8_libbase",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
   if (is_component_build) {
     # v8_parser_shell can't be built against a shared library, so we
     # need to depend on the underlying static target in that case.
     deps += [ ":v8_maybe_snapshot" ]
   } else {
@@ skipping 23 matching lines @@
 
     configs = [
       # Note: don't use :internal_config here because this target will get
       # the :external_config applied to it by virtue of depending on :v8, and
       # you can't have both applied to the same target.
       ":internal_config_base",
     ]
 
     deps = [
       ":v8",
-      ":v8_libbase",
       ":v8_libplatform",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
 
     if (v8_enable_i18n_support) {
       deps += [ "//third_party/icu" ]
     }
   }
 }
@@ skipping 279 matching lines @@
   ]
 
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 }
 
 v8_fuzzer("wasm_data_section_fuzzer") {
 }