Issue 23961005: Pass isolate to v8 integers factory functions

Issue 23961005: Pass isolate to v8 integers factory functions (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken, marja

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Pass isolate to v8 integers factory functions Pass isolate to v8 integers factory functions to avoid implicit call to v8::Isolate::GetCurrent(). R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157669

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -46 lines)			Patch
M	Source/bindings/v8/Dictionary.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/IDBBindingUtilities.cpp	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/bindings/v8/ScriptDebugServer.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/ScriptPromiseResolverTest.cpp	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/bindings/v8/ScriptValue.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/bindings/v8/custom/V8BlobCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8PromiseCustom.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/custom/V8PromiseCustom.cpp	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/bindings/v8/custom/V8PromiseResolverCustom.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/inspector/JavaScriptCallFrame.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23961005/1

7 years, 3 months ago (2013-09-12 09:24:00 UTC) #4

Message was sent while issue was closed.

Change committed as 157669

Expand Messages | Collapse Messages