Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Side by Side Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 23961005: Pass isolate to v8 integers factory functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseResolverCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 v8::Handle<v8::Value> result = restartFunction->Call(callFrame, 0, 0); 143 v8::Handle<v8::Value> result = restartFunction->Call(callFrame, 0, 0);
144 v8::Debug::SetLiveEditEnabled(false); 144 v8::Debug::SetLiveEditEnabled(false);
145 return result; 145 return result;
146 } 146 }
147 147
148 v8::Handle<v8::Value> JavaScriptCallFrame::setVariableValue(int scopeNumber, con st String& variableName, v8::Handle<v8::Value> newValue) 148 v8::Handle<v8::Value> JavaScriptCallFrame::setVariableValue(int scopeNumber, con st String& variableName, v8::Handle<v8::Value> newValue)
149 { 149 {
150 v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate); 150 v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
151 v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function> ::Cast(callFrame->Get(v8::String::NewSymbol("setVariableValue"))); 151 v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function> ::Cast(callFrame->Get(v8::String::NewSymbol("setVariableValue")));
152 v8::Handle<v8::Value> argv[] = { 152 v8::Handle<v8::Value> argv[] = {
153 v8::Handle<v8::Value>(v8::Integer::New(scopeNumber)), 153 v8::Handle<v8::Value>(v8::Integer::New(scopeNumber, m_isolate)),
154 v8String(variableName, m_isolate), 154 v8String(variableName, m_isolate),
155 newValue 155 newValue
156 }; 156 };
157 return setVariableValueFunction->Call(callFrame, 3, argv); 157 return setVariableValueFunction->Call(callFrame, 3, argv);
158 } 158 }
159 159
160 } // namespace WebCore 160 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseResolverCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698