Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp

Issue 23961005: Pass isolate to v8 integers factory functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseCustom.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
diff --git a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
index 19c8da7ee8fa5048bcb9f03cd075d47b1087aac7..b7c9cc96eda167797e0f4a64b394f5805f8b1adb 100644
--- a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
+++ b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
@@ -45,9 +45,9 @@ void V8PromiseResolver::fulfillMethodCustom(const v8::FunctionCallbackInfo<v8::V
v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
return;
- V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet);
-
v8::Isolate* isolate = args.GetIsolate();
+ V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
+
v8::Local<v8::Value> result = v8::Undefined();
if (args.Length() > 0)
result = args[0];
@@ -62,9 +62,9 @@ void V8PromiseResolver::resolveMethodCustom(const v8::FunctionCallbackInfo<v8::V
v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
return;
- V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet);
-
v8::Isolate* isolate = args.GetIsolate();
+ V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
+
v8::Local<v8::Value> result = v8::Undefined();
if (args.Length() > 0)
result = args[0];
@@ -79,9 +79,9 @@ void V8PromiseResolver::rejectMethodCustom(const v8::FunctionCallbackInfo<v8::Va
v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
return;
- V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet);
-
v8::Isolate* isolate = args.GetIsolate();
+ V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlagSet, isolate);
+
v8::Local<v8::Value> result = v8::Undefined();
if (args.Length() > 0)
result = args[0];
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseCustom.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698