Source/bindings/v8/ScriptPromiseResolverTest.cpp - Issue 23961005: Pass isolate to v8 integers factory functions

Unified Diff: Source/bindings/v8/ScriptPromiseResolverTest.cpp

Issue 23961005: Pass isolate to v8 integers factory functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: Source/bindings/v8/ScriptPromiseResolverTest.cpp

diff --git a/Source/bindings/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/v8/ScriptPromiseResolverTest.cpp

index 41fdf8934c0d9765d5968086f8d31b52505b4cc2..21fe80c7d53599ec6f722f665e0588a753005847 100644

--- a/Source/bindings/v8/ScriptPromiseResolverTest.cpp

+++ b/Source/bindings/v8/ScriptPromiseResolverTest.cpp

@@ -106,7 +106,7 @@ TEST_F(ScriptPromiseResolverTest, fulfill)

EXPECT_EQ(V8PromiseCustom::Pending, state());

EXPECT_TRUE(result()->IsUndefined());

- m_resolver->fulfill(ScriptValue(v8::Integer::New(3)));

+ m_resolver->fulfill(ScriptValue(v8::Integer::New(3, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

@@ -120,7 +120,7 @@ TEST_F(ScriptPromiseResolverTest, resolve)

EXPECT_EQ(V8PromiseCustom::Pending, state());

EXPECT_TRUE(result()->IsUndefined());

- m_resolver->resolve(ScriptValue(v8::Integer::New(3)));

+ m_resolver->resolve(ScriptValue(v8::Integer::New(3, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

@@ -134,7 +134,7 @@ TEST_F(ScriptPromiseResolverTest, reject)

EXPECT_EQ(V8PromiseCustom::Pending, state());

EXPECT_TRUE(result()->IsUndefined());

- m_resolver->reject(ScriptValue(v8::Integer::New(3)));

+ m_resolver->reject(ScriptValue(v8::Integer::New(3, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Rejected, state());

@@ -148,14 +148,14 @@ TEST_F(ScriptPromiseResolverTest, fulfillOverFulfill)

EXPECT_EQ(V8PromiseCustom::Pending, state());

EXPECT_TRUE(result()->IsUndefined());

- m_resolver->fulfill(ScriptValue(v8::Integer::New(3)));

+ m_resolver->fulfill(ScriptValue(v8::Integer::New(3, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

ASSERT_TRUE(result()->IsNumber());

EXPECT_EQ(3, result().As<v8::Integer>()->Value());

- m_resolver->fulfill(ScriptValue(v8::Integer::New(4)));

+ m_resolver->fulfill(ScriptValue(v8::Integer::New(4, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

ASSERT_TRUE(result()->IsNumber());

@@ -168,14 +168,14 @@ TEST_F(ScriptPromiseResolverTest, rejectOverFulfill)

EXPECT_EQ(V8PromiseCustom::Pending, state());

EXPECT_TRUE(result()->IsUndefined());

- m_resolver->fulfill(ScriptValue(v8::Integer::New(3)));

+ m_resolver->fulfill(ScriptValue(v8::Integer::New(3, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

ASSERT_TRUE(result()->IsNumber());

EXPECT_EQ(3, result().As<v8::Integer>()->Value());

- m_resolver->reject(ScriptValue(v8::Integer::New(4)));

+ m_resolver->reject(ScriptValue(v8::Integer::New(4, m_isolate)));

EXPECT_FALSE(m_resolver->isPending());

EXPECT_EQ(V8PromiseCustom::Fulfilled, state());

ASSERT_TRUE(result()->IsNumber());

« no previous file with comments | « Source/bindings/v8/ScriptDebugServer.cpp ('k') | Source/bindings/v8/ScriptValue.cpp » ('j') | no next file with comments »