Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2395993002: Add type casts for KeyframeEffectReadOnly (Closed)

Created:
4 years, 2 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 2 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type casts for KeyframeEffectReadOnly The following type hierarchy exists in core/animation: KeyframeEffect is a subclass of KeyframeEffectReadOnly is a subclass of AnimationEffectReadOnly. Type casts have already been defined to convert AnimationEffectReadOnly objects to KeyframeEffect objects; this patch adds the equivalent for converting to KeyframeEffectReadOnly. Committed: https://crrev.com/76ec34ae2976574a0b49a95f6bebddf33b1bd9e5 Cr-Commit-Position: refs/heads/master@{#423758}

Patch Set 1 #

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h View 1 2 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
suzyh_UTC10 (ex-contributor)
4 years, 2 months ago (2016-10-06 01:55:01 UTC) #2
alancutter (OOO until 2018)
lgtm. Add TODO for converting calls to toKeyframeEffect into toKeyframeEffectReadOnly where appropriate or do it ...
4 years, 2 months ago (2016-10-06 02:09:23 UTC) #3
suzyh_UTC10 (ex-contributor)
On 2016/10/06 at 02:09:23, alancutter wrote: > lgtm. Add TODO for converting calls to toKeyframeEffect ...
4 years, 2 months ago (2016-10-06 02:17:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395993002/20001
4 years, 2 months ago (2016-10-06 22:58:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 00:27:19 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:29:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76ec34ae2976574a0b49a95f6bebddf33b1bd9e5
Cr-Commit-Position: refs/heads/master@{#423758}

Powered by Google App Engine
This is Rietveld 408576698