Move content up to KeyframeEffectReadOnly

Move content up to KeyframeEffectReadOnly

This patch completes the bulk of the move of content from KeyframeEffect to its
superclass KeyframeEffectReadOnly, as a step towards fixing the bug described in
https://codereview.chromium.org/2389323003.

This change requires the SampledEffect's m_effect member to change from a
KeyframeEffect to a KeyframeEffectReadOnly, which causes a couple of small
flow-on changes.

BUG=624639
Committed: https://crrev.com/97d82465ceeeb904b0f1d3a7ed54667926b45123
Cr-Commit-Position: refs/heads/master@{#424112}

[suzyh_UTC10 (ex-contributor), 2016-10-06 03:37:17]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-10-07 00:46:00]

https://codereview.chromium.org/2397113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/KeyframeEffect.h (left):

https://codereview.chromium.org/2397113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/KeyframeEffect.h:141: friend class
AnimationAnimationV8Test;
Oh yes, I meant to comment on this. The AnimationAnimationV8Test class was
renamed AnimationKeyframeEffectV8Test some time ago. Since nothing broke,
evidently this friend class statement is no longer needed.

[alancutter (OOO until 2018), 2016-10-10 00:46:25]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-10-10 00:54:16]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-10-10 00:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 02:28:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-10 02:30:23]

Description was changed from

==========
Move content up to KeyframeEffectReadOnly

This patch completes the bulk of the move of content from KeyframeEffect to its
superclass KeyframeEffectReadOnly, as a step towards fixing the bug described in
https://codereview.chromium.org/2389323003.

This change requires the SampledEffect's m_effect member to change from a
KeyframeEffect to a KeyframeEffectReadOnly, which causes a couple of small
flow-on changes.

BUG=624639
==========

to

==========
Move content up to KeyframeEffectReadOnly

This patch completes the bulk of the move of content from KeyframeEffect to its
superclass KeyframeEffectReadOnly, as a step towards fixing the bug described in
https://codereview.chromium.org/2389323003.

This change requires the SampledEffect's m_effect member to change from a
KeyframeEffect to a KeyframeEffectReadOnly, which causes a couple of small
flow-on changes.

BUG=624639

Committed: https://crrev.com/97d82465ceeeb904b0f1d3a7ed54667926b45123
Cr-Commit-Position: refs/heads/master@{#424112}
==========

[commit-bot: I haz the power, 2016-10-10 02:30:23]

Patchset 1 (id:??) landed as
https://crrev.com/97d82465ceeeb904b0f1d3a7ed54667926b45123
Cr-Commit-Position: refs/heads/master@{#424112}