Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2394993002: Move Priority enum/field to KeyframeEffectReadOnly (Closed)

Created:
4 years, 2 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 2 months ago
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Priority enum/field to KeyframeEffectReadOnly Following from https://codereview.chromium.org/2389323003, this patch begins the process of moving content from KeyframeEffect to its superclass, KeyframeEffectReadOnly, so that KeyframeEffectReadOnly objects can be constructed directly. This patch moves the definition of the Priority enum and the m_priority field. BUG=624639 Committed: https://crrev.com/65aaa5e663e316c1ea35bf487aa32a965459475f Cr-Commit-Position: refs/heads/master@{#423478}

Patch Set 1 #

Messages

Total messages: 19 (10 generated)
suzyh_UTC10 (ex-contributor)
4 years, 2 months ago (2016-10-05 22:40:58 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 2 months ago (2016-10-05 23:04:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394993002/1
4 years, 2 months ago (2016-10-06 00:51:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/274880)
4 years, 2 months ago (2016-10-06 01:01:34 UTC) #10
suzyh_UTC10 (ex-contributor)
+dstockwell for core Feel free to send to the CQ if OK
4 years, 2 months ago (2016-10-06 01:10:04 UTC) #12
fs
lgtm rs
4 years, 2 months ago (2016-10-06 07:21:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394993002/1
4 years, 2 months ago (2016-10-06 07:22:06 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 08:42:24 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:44:49 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65aaa5e663e316c1ea35bf487aa32a965459475f
Cr-Commit-Position: refs/heads/master@{#423478}

Powered by Google App Engine
This is Rietveld 408576698