Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2395503002: WebRTCStatsMember: Support for bool and sequence of bool (Closed)

Created:
4 years, 2 months ago by hbos_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, posciak+watch_chromium.org, jam, haraken, feature-media-reviews_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews, darin-cc_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRTCStatsMember: Support for bool and sequence of bool. Allows RTCStats[1] dictionaries to contain "boolean" and "sequence<boolean>". This is a follow-up surfacing the bool types added in WebRTC-CL: https://codereview.webrtc.org/2387343002/ [1] https://w3c.github.io/webrtc-stats/ BUG=chromium:627816 Committed: https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7 Cr-Commit-Position: refs/heads/master@{#424180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M components/test_runner/mock_webrtc_peer_connection_handler.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 4 chunks +9 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/rtc_stats.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.cc View 4 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp View 3 chunks +23 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCStats.h View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
hbos_chromium
Please take a look, hta and mkwst. hta for stats stuff. mkwst for owner of: ...
4 years, 2 months ago (2016-10-06 09:52:11 UTC) #7
Mike West
On 2016/10/06 at 09:52:11, hbos wrote: > mkwst for owner of: > components/test_runner/mock_webrtc_peer_connection_handler.cc > third_party/WebKit/public/platform/WebRTCStats.h ...
4 years, 2 months ago (2016-10-06 11:26:38 UTC) #11
hbos_chromium
Bump, PTAL hta
4 years, 2 months ago (2016-10-10 16:18:57 UTC) #12
hta - Chromium
lgtm
4 years, 2 months ago (2016-10-10 16:22:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395503002/40001
4 years, 2 months ago (2016-10-10 16:23:14 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-10-10 17:44:08 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:48:32 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8c226e007d63aa93bda532cb1ed2ebc9c3292b7
Cr-Commit-Position: refs/heads/master@{#424180}

Powered by Google App Engine
This is Rietveld 408576698