Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: components/test_runner/mock_webrtc_peer_connection_handler.cc

Issue 2395503002: WebRTCStatsMember: Support for bool and sequence of bool (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/rtc_peer_connection_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/mock_webrtc_peer_connection_handler.cc
diff --git a/components/test_runner/mock_webrtc_peer_connection_handler.cc b/components/test_runner/mock_webrtc_peer_connection_handler.cc
index 50c3f5b09dd8e5a92f88b7ddcc3cf754bf11edfb..b4d451d55fb2c587937c8711768db13e5cdec335 100644
--- a/components/test_runner/mock_webrtc_peer_connection_handler.cc
+++ b/components/test_runner/mock_webrtc_peer_connection_handler.cc
@@ -127,6 +127,7 @@ class MockWebRTCStatsMember : public blink::WebRTCStatsMember {
return type_;
}
bool isDefined() const override { return true; }
+ bool valueBool() const override { return true; }
int32_t valueInt32() const override { return 42; }
uint32_t valueUint32() const override { return 42; }
int64_t valueInt64() const override { return 42; }
@@ -135,6 +136,9 @@ class MockWebRTCStatsMember : public blink::WebRTCStatsMember {
blink::WebString valueString() const override {
return blink::WebString::fromUTF8("42");
}
+ WebVector<int> valueSequenceBool() const override {
+ return sequenceWithValue<int>(1);
+ }
WebVector<int32_t> valueSequenceInt32() const override {
return sequenceWithValue<int32_t>(42);
}
@@ -519,12 +523,14 @@ void MockWebRTCPeerConnectionHandler::getStats(
std::unique_ptr<blink::WebRTCStatsReportCallback> callback) {
std::unique_ptr<MockWebRTCStatsReport> report(new MockWebRTCStatsReport());
MockWebRTCStats stats("mock-stats-01", "mock-stats", 1234.0);
+ stats.addMember("bool", blink::WebRTCStatsMemberTypeBool);
stats.addMember("int32", blink::WebRTCStatsMemberTypeInt32);
stats.addMember("uint32", blink::WebRTCStatsMemberTypeUint32);
stats.addMember("int64", blink::WebRTCStatsMemberTypeInt64);
stats.addMember("uint64", blink::WebRTCStatsMemberTypeUint64);
stats.addMember("double", blink::WebRTCStatsMemberTypeDouble);
stats.addMember("string", blink::WebRTCStatsMemberTypeString);
+ stats.addMember("sequenceBool", blink::WebRTCStatsMemberTypeSequenceBool);
stats.addMember("sequenceInt32", blink::WebRTCStatsMemberTypeSequenceInt32);
stats.addMember("sequenceUint32", blink::WebRTCStatsMemberTypeSequenceUint32);
stats.addMember("sequenceInt64", blink::WebRTCStatsMemberTypeSequenceInt64);
« no previous file with comments | « no previous file | content/renderer/media/rtc_peer_connection_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698